extended params accepted by notification to support from (aka. labels)#63
Open
lv10 wants to merge 1 commit intoRidersDiscountCom:masterfrom
lv10:master
Open
extended params accepted by notification to support from (aka. labels)#63lv10 wants to merge 1 commit intoRidersDiscountCom:masterfrom lv10:master
lv10 wants to merge 1 commit intoRidersDiscountCom:masterfrom
lv10:master
Conversation
| 'message': message, | ||
| 'notify': notify, | ||
| 'message_format': format, | ||
| 'from': 'labe'} |
There was a problem hiding this comment.
I think it should be 'from': 'label'} instead.
|
I need to be able to specify Is there any estimation when this PR will be merged ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended notification functionality to support 'from' parameter the send_notification endpoint as per API's documentation https://www.hipchat.com/docs/apiv2/method/send_room_notification.
I also considered passing **kwargs and let the API decided if request is incorrect or not. If you'd like to do that instead, let me know and I'll change the code and resubmit.
Thank you.