Add ledger entity API endpoints and supporting models#71
Merged
Conversation
## Summary This commit introduces the `LedgerEntityResponse` and `UpdateEntityRequest` models to the client library, enhancing support for ledger and entity management. Additionally, the `MaterializeRequest` class is updated to include a new `source` parameter, allowing for better specification of data sources during materialization. ## Key Accomplishments - **New Models**: Added `LedgerEntityResponse` and `UpdateEntityRequest` to improve API capabilities. - **MaterializeRequest Update**: Introduced `source` parameter to the `MaterializeRequest` class, with appropriate serialization and deserialization logic. ## Changes Breakdown - Updated `models/__init__.py` to include new model imports and registrations. - Modified `materialize_request.py` to add the `source` parameter and its handling in the `to_dict` and `from_dict` methods. ## Testing Notes - Verify that the new models are correctly integrated and accessible. - Ensure that the `source` parameter functions as expected in materialization requests. ## Infrastructure Considerations - No breaking changes introduced; existing functionality remains intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces ledger entity support to the robosystems client library by adding new API endpoints for retrieving and updating ledger entities, along with their corresponding request/response models. Also includes a minor update to the existing
MaterializeRequestclass.Key Accomplishments
New API Endpoints
get_ledger_entity– New endpoint for fetching ledger entity data from the API, with full support for both sync and async HTTP clientsupdate_ledger_entity– New endpoint for updating ledger entities, also supporting both sync and async execution patternsNew Models
LedgerEntityResponse– Comprehensive response model (623 lines) for deserializing ledger entity data returned by the APIUpdateEntityRequest– Request model (498 lines) for constructing and validating ledger entity update payloadsUpdated Models
MaterializeRequest– Updated with additional field(s) to support new ledger entity functionalitymodels/__init__.py– Updated exports to include the newly added modelsBreaking Changes
MaterializeRequestmodel has been modified with field changes. Consumers relying on the previous structure of this class should verify compatibility, though the change appears to be additive in nature (net +23 lines).Testing Notes
get_ledger_entityreturns properly deserializedLedgerEntityResponseobjects for valid entity lookupsupdate_ledger_entitycorrectly serializesUpdateEntityRequestpayloads and handles success/error responsesMaterializeRequestchanges do not regress existing materialization workflowsInfrastructure Considerations
🤖 Generated with Claude Code
Branch Info:
feature/ledger-entitymainCo-Authored-By: Claude noreply@anthropic.com