Skip to content

added topic_based_ros2_control #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
traversaro merged 4 commits into from
Sep 10, 2025
Merged

added topic_based_ros2_control #346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
746ff6b
added topic_based_ros2_control to vinca.yaml see https://github.com/R…
TedVanderfeen Sep 10, 2025
5e9fbb3
MacOS build failing. Moved to linux only target section
TedVanderfeen Sep 10, 2025
ab438df
Backport PR 36 for topic-based-ros2-control
traversaro Sep 10, 2025
e57a4c9
Move topic_based_ros2_control back to all non-wasm packages
traversaro Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions patch/ros-humble-topic-based-ros2-control.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
From 546fa2b161d178b1cdb896ba90887419b1b702de Mon Sep 17 00:00:00 2001
From: Bence Magyar <bence.magyar.robotics@gmail.com>
Date: Sat, 16 Aug 2025 07:10:52 +0100
Subject: [PATCH] Deprecation notices should be seen. Do not convert warnings
into errors.

---
CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 3a8e525..7b8bb21 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 3.16)
project(topic_based_ros2_control CXX)

if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
- add_compile_options(-Werror -Wall -Wextra -Wpedantic -Wshadow
+ add_compile_options(-Wall -Wextra -Wpedantic -Wshadow
-Wsign-conversion -Winit-self -Wredundant-decls)
endif()

4 changes: 3 additions & 1 deletion vinca.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,9 @@ packages_select_by_deps:
- imu_tools
- rplidar_ros
- vector_pursuit_controller

# Requested in https://github.com/RoboStack/ros-humble/issues/345
- topic_based_ros2_control

# These packages are only built on Linux as they depend on Linux-specific API
- if: linux
then:
Expand Down
Loading