Skip to content

Update pinnings (mainly assimp 6)#81

Draft
diegoferigo-rai wants to merge 4 commits into
RoboStack:mainfrom
diegoferigo-rai:diegoferigo/update-pins
Draft

Update pinnings (mainly assimp 6)#81
diegoferigo-rai wants to merge 4 commits into
RoboStack:mainfrom
diegoferigo-rai:diegoferigo/update-pins

Conversation

@diegoferigo-rai
Copy link
Copy Markdown
Contributor

@diegoferigo-rai diegoferigo-rai commented May 26, 2026

Follows up:

that achieved a successful rebuild without updating any package pinning (from #79 (comment)).

Hopefully fixing:

@Tobias-Fischer
Copy link
Copy Markdown
Contributor

Thanks @diegoferigo-rai! I'd be keen to fix #76 while we are at it .. @diegoferigo-rai @traversaro @eholum would any of you be happy to try @traversaro's suggested patch?

@Tobias-Fischer
Copy link
Copy Markdown
Contributor

Same error as RoboStack/ros-jazzy#212 (comment)

@Tobias-Fischer
Copy link
Copy Markdown
Contributor

What do you think we should do here @traversaro ?

@traversaro
Copy link
Copy Markdown
Member

What do you think we should do here @traversaro ?

I would just revert the patch to https://github.com/RoboStack/ros-jazzy/blob/main/patch/ros-jazzy-rosidl-generator-py.osx.patch, perhaps by just changing the line target_include_directories(${_target_name_lib} PUBLIC ${Python3_INCLUDE_DIRS} ${Python3_NumPy_INCLUDE_DIRS}) to target_include_directories(${_target_name_lib} PRIVATE ${Python3_INCLUDE_DIRS} ${Python3_NumPy_INCLUDE_DIRS}) to also fix RoboStack/ros-jazzy#213 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants