Skip to content

resolve missing unique key prop warnings in ChatInputFormattingToolbar #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Suraj704-glitch wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

resolve missing unique key prop warnings in ChatInputFormattingToolbar #1118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 28 additions & 27 deletions packages/react/src/views/ChatInput/ChatInputFormattingToolbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState, useRef, useEffect } from 'react';
import React, { useState, useRef } from 'react';
import { css } from '@emotion/react';
import {
Box,
Expand Down Expand Up @@ -87,7 +87,7 @@ const ChatInputFormattingToolbar = ({
emoji:
isPopoverOpen && popOverItems.includes('emoji') ? (
<Box
key="emoji"
key="emoji-popover"
css={styles.popOverItemStyles}
disabled={isRecordingMessage}
onClick={() => {
Expand Down Expand Up @@ -116,6 +116,7 @@ const ChatInputFormattingToolbar = ({

audio: (
<AudioMessageRecorder
key="audio-recorder"
displayName={
isPopoverOpen && popOverItems.includes('audio') ? 'audio' : null
}
Expand All @@ -125,6 +126,7 @@ const ChatInputFormattingToolbar = ({
),
video: (
<VideoMessageRecorder
key="video-recorder"
displayName={
isPopoverOpen && popOverItems.includes('video') ? 'video' : null
}
Expand All @@ -135,7 +137,7 @@ const ChatInputFormattingToolbar = ({
file:
isPopoverOpen && popOverItems.includes('file') ? (
<Box
key="file"
key="file-popover"
css={styles.popOverItemStyles}
disabled={isRecordingMessage}
onClick={() => {
Expand All @@ -147,7 +149,7 @@ const ChatInputFormattingToolbar = ({
<span>file</span>
</Box>
) : (
<Tooltip text="Upload File" position="top" key="file">
<Tooltip text="Upload File" position="top" key="file-btn">
<ActionButton
square
ghost
Expand All @@ -164,7 +166,7 @@ const ChatInputFormattingToolbar = ({
link:
isPopoverOpen && popOverItems.includes('link') ? (
<Box
key="link"
key="link-popover"
css={styles.popOverItemStyles}
disabled={isRecordingMessage}
onClick={() => {
Expand All @@ -176,7 +178,7 @@ const ChatInputFormattingToolbar = ({
<span>link</span>
</Box>
) : (
<Tooltip text="Link" position="top" key="link">
<Tooltip text="Link" position="top" key="link-btn">
<ActionButton
square
ghost
Expand All @@ -194,29 +196,27 @@ const ChatInputFormattingToolbar = ({
.map((name) => formatter.find((item) => item.name === name))
.map((item) =>
isPopoverOpen && popOverItems.includes('formatter') ? (
<>
<Box
key={item.name}
<Box
key={`popover-${item.name}`}
disabled={isRecordingMessage}
onClick={() => {
if (isRecordingMessage) return;
handleFormatterClick(item);
}}
css={styles.popOverItemStyles}
>
<Icon
disabled={isRecordingMessage}
onClick={() => {
if (isRecordingMessage) return;
handleFormatterClick(item);
}}
css={styles.popOverItemStyles}
>
<Icon
disabled={isRecordingMessage}
name={item.name}
size="1rem"
/>
<span>{item.name}</span>
</Box>
</>
name={item.name}
size="1rem"
/>
<span>{item.name}</span>
</Box>
) : (
<Tooltip
text={item.name}
position="top"
key={`formatter-${item.name}`}
key={`surface-formatter-${item.name}`}
>
<ActionButton
square
Expand Down Expand Up @@ -263,7 +263,7 @@ const ChatInputFormattingToolbar = ({
if (itemInFormatter) {
return (
<Box
key={itemInFormatter.name}
key={`popover-item-${itemInFormatter.name}`}
disabled={isRecordingMessage}
onClick={() => handleFormatterClick(itemInFormatter)}
css={styles.popOverItemStyles}
Expand Down Expand Up @@ -296,7 +296,7 @@ const ChatInputFormattingToolbar = ({
<Tooltip
text={itemInFormatter.name}
position="top"
key={`formatter-${itemInFormatter.name}`}
key={`small-formatter-${itemInFormatter.name}`}
>
<ActionButton
square
Expand Down Expand Up @@ -351,6 +351,7 @@ const ChatInputFormattingToolbar = ({

{isInsertLinkOpen && (
<InsertLinkToolBox
key="link-toolbox"
selectedText={window.getSelection().toString()}
handleAddLink={handleAddLink}
onClose={() => setInsertLinkOpen(false)}
Expand All @@ -360,4 +361,4 @@ const ChatInputFormattingToolbar = ({
);
};

export default ChatInputFormattingToolbar;
export default ChatInputFormattingToolbar;