Secured search logic to prevent runtime crashes on API errors #1122
+45
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secured search logic to prevent runtime crashes on API errors
Acceptance Criteria fulfillment
[x] Task 1: Wrapped the getSearchMessages API call in a try-catch block to ensure the app stays alive during server hiccups.
[x] Task 2: Implemented defensive rendering using Optional Chaining (?.) when reading message counts, preventing the TypeError crash.
[x] Task 3: Validated the fix in the sandbox environment by simulating high-traffic search bursts and verifying the UI doesn't break.
Fixes # (issue)
Video/Screenshots
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace
<pr_number>with the actual PR number.