Skip to content

Conversation

@Suraj704-glitch
Copy link

Secured search logic to prevent runtime crashes on API errors

Acceptance Criteria fulfillment

[x] Task 1: Wrapped the getSearchMessages API call in a try-catch block to ensure the app stays alive during server hiccups.

[x] Task 2: Implemented defensive rendering using Optional Chaining (?.) when reading message counts, preventing the TypeError crash.

[x] Task 3: Validated the fix in the sandbox environment by simulating high-traffic search bursts and verifying the UI doesn't break.
Fixes # (issue)

Video/Screenshots

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants