[NEW] Add bottomSheet for members by shubhsherl · Pull Request #2002 · RocketChat/Rocket.Chat.Android

shubhsherl · 2019-01-20T10:49:46Z

Closes #1958

shubhsherl · 2019-02-26T13:06:06Z

Please review and merge this, before merging current PR.

hfeky · 2019-05-23T21:29:37Z

app/src/main/res/values-es/strings.xml

    <string name="submit">Submit</string> <!--TODO - Add proper translation-->
    <string name="required">*required</string> <!--TODO - Add proper translation-->
-    <string name="report_sent">Your report has been sent!</string> <!--TODO - Add proper translation-->
+    <string name="report_sent">Your report has been sent!</string>


This string needs to add TODO Translate.

hfeky · 2019-05-23T21:30:53Z

app/src/main/res/values-fr/strings.xml

-    <string name="submit">Soumettre</string>
-    <string name="required">*Obligatoire</string>
-    <string name="report_sent">Votre rapport a été envoyé!</string>
+    <string name="submit">Submit</string> <!-- TODO - Add proper translation -->


Those 3 strings are already translated above.

hfeky · 2019-05-23T21:32:52Z

app/src/main/res/values-ja/strings.xml

    <string name="submit">Submit</string> <!--TODO - Add proper translation-->
    <string name="required">*required</string> <!--TODO - Add proper translation-->
-    <string name="report_sent">Your report has been sent!</string> <!--TODO - Add proper translation-->
+    <string name="report_sent">Your report has been sent!</string>


This string needs to add TODO Translate.

hfeky · 2019-05-23T21:34:05Z

app/src/main/res/values-tr/strings.xml

    <string name="submit">Submit</string> <!--TODO - Add proper translation-->
    <string name="required">*required</string> <!--TODO - Add proper translation-->
-    <string name="report_sent">Your report has been sent!</string> <!--TODO - Add proper translation-->
+    <string name="report_sent">Your report has been sent!</string>


This string needs to add TODO Translate.

hfeky · 2019-05-23T21:35:30Z

app/src/main/res/values-uk/strings.xml

    <string name="submit">Submit</string> <!-- TODO - Add proper translation -->
    <string name="required">*required</string> <!-- TODO - Add proper translation -->
-    <string name="report_sent">Your report has been sent!</string> <!-- TODO - Add proper translation -->
+    <string name="report_sent">Your report has been sent!</string>


This string needs to add TODO Translate.

philipbrito · 2019-06-18T00:57:34Z

@shubhsherl Can you fix the conflicts here?

shubhsherl · 2019-06-20T17:43:07Z

@shubhsherl Can you fix the conflicts here?

@filipedelimabrito Sure, I will do it.

philipbrito · 2019-06-26T22:46:34Z

app/src/main/java/chat/rocket/android/chatdetails/ui/ChatDetailsFragment.kt

    isSubscribed: Boolean,
-    isFavorite: Boolean,
-    disableMenu: Boolean
+    disableMenu: Boolean,


Well, I think you wrong deleted the isFavorite param here.

philipbrito · 2019-06-26T22:47:08Z

app/src/main/java/chat/rocket/android/chatdetails/ui/ChatDetailsFragment.kt

    internal lateinit var chatRoomType: String
    private var isSubscribed: Boolean = true
-    internal var isFavorite: Boolean = false
+    private var isOwner: Boolean = false


Where is the isFavorite param?

philipbrito · 2019-06-26T22:47:38Z

app/src/main/java/chat/rocket/android/chatdetails/ui/ChatDetailsFragment.kt

+            isSubscribed = bundle.getBoolean(BUNDLE_IS_SUBSCRIBED)
+            disableMenu = bundle.getBoolean(BUNDLE_DISABLE_MENU)
+            isOwner = bundle.getBoolean(BUNDLE_CHAT_ROOM_OWNER)
+            isMod = bundle.getBoolean(BUNDLE_CHAT_ROOM_MOD)


Where is the isFavorite param? We have a bundle for it.

philipbrito · 2019-06-26T22:48:47Z

app/src/main/java/chat/rocket/android/chatroom/presentation/ChatRoomNavigator.kt

        isChatRoomSubscribed: Boolean,
-        isChatRoomFavorite: Boolean,
-        isMenuDisabled: Boolean
+        isMenuDisabled: Boolean,


Where is the isFavorite param?

philipbrito · 2019-06-26T22:49:23Z

app/src/main/java/chat/rocket/android/chatroom/presentation/ChatRoomPresenter.kt

        isMenuDisabled: Boolean
    ) {
-        navigator.toChatDetails(chatRoomId, chatRoomType, isSubscribed, isFavorite, isMenuDisabled)
+        navigator.toChatDetails(chatRoomId, chatRoomType, isSubscribed, isMenuDisabled, isOwner(), isModerator())


Where is the isFavorite param?

philipbrito · 2019-06-26T22:54:39Z

app/src/main/java/chat/rocket/android/members/presentation/MembersPresenter.kt

+                    }
+                notifier()
+            } catch (ex: RocketChatException) {
+                view.showMessage(ex.message!!) // TODO Remove.


This is not the way to go. Check how we are handling our exceptions on our codebase please. There are lots of examples demonstrating how to handle it.

philipbrito · 2019-06-26T22:54:44Z

app/src/main/java/chat/rocket/android/members/presentation/MembersPresenter.kt

+                notifier()
+                view.setMemberCount(--totalMembers)
+            } catch (ex: RocketChatException) {
+                view.showMessage(ex.message!!) // TODO Remove.


This is not the way to go. Check how we are handling our exceptions on our codebase please. There are lots of examples demonstrating how to handle it.

philipbrito · 2019-06-26T22:54:52Z

app/src/main/java/chat/rocket/android/members/presentation/MembersPresenter.kt

+                    retryIO(description = "addOwner($roomId, $roomType, $userId)") { client.addOwner(roomId, roomType, userId) }
+                notifier()
+            } catch (ex: RocketChatException) {
+                view.showMessage(ex.message!!) // TODO Remove.


This is not the way to go. Check how we are handling our exceptions on our codebase please. There are lots of examples demonstrating how to handle it.

philipbrito · 2019-06-26T22:55:39Z

app/src/main/java/chat/rocket/android/members/ui/MembersFragment.kt

-    arguments = Bundle(1).apply {
-        putString(BUNDLE_CHAT_ROOM_ID, chatRoomId)
+
+fun newInstance(chatRoomId: String, isOwner: Boolean, isMod: Boolean): Fragment {


isModerator sounds better than isMod. You have even created a function with that name on ChatRoomPresenter.kt for instance.

philipbrito · 2019-06-26T22:56:10Z

app/src/main/java/chat/rocket/android/members/ui/MembersFragment.kt

-                    it,
-                    DividerItemDecoration.HORIZONTAL
-                )
+                    DividerItemDecoration(


Wrong indentation. Could you please fix it?

philipbrito · 2019-07-18T00:12:24Z

@shubhsherl Are you going to do the necessary things here in order to merge your PR?

shubhsherl · 2019-07-27T10:02:33Z

@shubhsherl Are you going to do the necessary things here to merge your PR?

Sorry, @filipedelimabrito I am currently involved in other projects. Unable to work on it right now.

philipbrito · 2019-07-29T09:28:35Z

We'll try to fix it ourselves. Thanks for letting us know @shubhsherl

shubhsherl force-pushed the n_1958 branch from 3ea8d12 to 8282965 Compare February 10, 2019 17:45

shubhsherl changed the title ~~[WIP] Add bottomSheet for members~~ Add bottomSheet for members Feb 26, 2019

shubhsherl changed the title ~~Add bottomSheet for members~~ [NEW] Add bottomSheet for members Feb 26, 2019

shubhsherl and others added 6 commits March 19, 2019 09:38

add bottomSheet for members

ade0317

add mute functionality

f5d8e22

navigate members

d7aaf98

notify member list

cedf828

filter menuitem on roles

793e2cc

add icon, update string files

0839e81

shubhsherl force-pushed the n_1958 branch from fdaad2b to 0839e81 Compare March 19, 2019 04:19

hfeky suggested changes May 23, 2019

View reviewed changes

philipbrito added this to the 3.5.0 milestone Jun 18, 2019

philipbrito suggested changes Jun 26, 2019

View reviewed changes

Conversation

shubhsherl commented Jan 20, 2019

Uh oh!

shubhsherl commented Feb 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

philipbrito commented Jun 18, 2019

Uh oh!

shubhsherl commented Jun 20, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

philipbrito commented Jul 18, 2019

Uh oh!

shubhsherl commented Jul 27, 2019

Uh oh!

philipbrito commented Jul 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shubhsherl commented Feb 26, 2019 •

edited

Loading