fix: ensure supportedVersions cache is created with secure permissions (0600)#3148
fix: ensure supportedVersions cache is created with secure permissions (0600)#3148Nitinref wants to merge 1 commit intoRocketChat:masterfrom
Conversation
…event permission errors
WalkthroughModifies Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I have created a pull request to fix this issue: #3148. |
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
src/servers/supportedVersions/main.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Follow existing TypeScript patterns with strict mode enabled
All new code must pass ESLint and TypeScript checks
Avoid unnecessary comments; only add comments for complex logic or non-obvious decisions
Files:
src/servers/supportedVersions/main.ts
🧬 Code graph analysis (1)
src/servers/supportedVersions/main.ts (1)
src/servers/supportedVersions/types.ts (1)
SupportedVersions(33-45)
🪛 ESLint
src/servers/supportedVersions/main.ts
[error] 51-51: Insert {
(prettier/prettier)
[error] 52-52: Replace ·{·[key:·string]:·SupportedVersions·} with ·[key:·string]:·SupportedVersions;
(prettier/prettier)
[error] 53-54: Replace >(⏎·· with }>(
(prettier/prettier)
[error] 55-55: Delete ··
(prettier/prettier)
[error] 56-56: Delete ··
(prettier/prettier)
[error] 57-59: Replace ··}·as·unknown·as·MyStoreOptions⏎);⏎ with }·as·unknown·as·MyStoreOptions);
(prettier/prettier)
[error] 81-81: Delete ··
(prettier/prettier)
[error] 82-82: Replace ······ with ····
(prettier/prettier)
[error] 83-83: Delete ··
(prettier/prettier)
[error] 84-84: Delete ··
(prettier/prettier)
[error] 85-85: Delete ··
(prettier/prettier)
[error] 86-86: Delete ··
(prettier/prettier)
[error] 87-87: Delete ··
(prettier/prettier)
[error] 88-88: Delete ··
(prettier/prettier)
[error] 89-89: Delete ··
(prettier/prettier)
[error] 90-90: Delete ··
(prettier/prettier)
[error] 91-91: Delete ··
(prettier/prettier)
[error] 92-92: Delete ··
(prettier/prettier)
[error] 93-93: Delete ··
(prettier/prettier)
[error] 94-94: Delete ··
(prettier/prettier)
[error] 95-95: Delete ··
(prettier/prettier)
This PR fixes incorrect permission mode for the
supportedVersionsElectronStore cache file.The file was created with default permissions (~644), which caused permission errors when reading the cache in some environments.
This fix sets
fileMode: 0o600so the cache is readable and writable only by the current user.Tested on Windows and WSL — the cache file is now created with 600 permissions.
Screenshot:

Closes #3147
Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.