This repository was archived by the owner on Jun 7, 2020. It is now read-only.
[NEW] Project 02 - Changing and adding servers VoiceOver accessible #2750
Open
rudrankriyam wants to merge 4 commits intoRocketChat:developfrom
Open
[NEW] Project 02 - Changing and adding servers VoiceOver accessible #2750rudrankriyam wants to merge 4 commits intoRocketChat:developfrom
rudrankriyam wants to merge 4 commits intoRocketChat:developfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2750 +/- ##
===========================================
- Coverage 46.1% 44.54% -1.57%
===========================================
Files 626 626
Lines 28938 28943 +5
===========================================
- Hits 13343 12892 -451
- Misses 15595 16051 +456
Continue to review full report at Codecov.
|
rudrankriyam
changed the title
rudrankriyam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@RocketChat/ios
Adding a new server follows the same steps as from the main authentication screen, with the option of sign up and login. It has been covered in the previous project.
Servers can be added and changed using the ServersListView.
However, instead of tapping the current server, double tapping on Messages opens and closes the ServersListView instead, which needs to be changed.
Adding a comma between the accessibility label of Rocket.Chat and serverURL sounds a bit better by creating pause in VoiceOver dictation.
Accessibility notifications for screen and layout changes