[bugfix] Fixed Cannot read property _id of undefined#132
Open
bkrith wants to merge 1 commit into
Open
Conversation
|
|
Member
|
hey @bkrith which version of rocket.chat are you using? I'm afraid we fixed this issue here RocketChat/Rocket.Chat#20930 although your suggestion "fixes" the "expected" behavior/issue, we shouldn't be receiving an array of messages (even more an array containing an single item) no matter what, that's because the error was server-side problem! can you check if my explanation makes sense? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a check for message object if is an Array and fix some extra compiling issues in Typescript.