chore!: remove Allow Anonymous Write setting and anonymous role - #41828
chore!: remove Allow Anonymous Write setting and anonymous role#41828KevLehman wants to merge 6 commits into
Conversation
Removes Accounts_AllowAnonymousWrite, the "Or talk as anonymous" composer action and the anonymous branch of the registerUser method. Follow-up to the deprecation note (CORE-1514). Setting document is deleted on upgrade.
Drops the anonymous role from default permissions, role seeding and role priority, removes the afterVerifyEmail method (its only job was promoting anonymous users), and deletes the role/permission entries on upgrade.
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 5a26e27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-9.0.0 #41828 +/- ##
=================================================
- Coverage 69.35% 68.84% -0.51%
=================================================
Files 4201 4133 -68
Lines 166609 158124 -8485
Branches 29743 28062 -1681
=================================================
- Hits 115549 108858 -6691
+ Misses 45920 44119 -1801
- Partials 5140 5147 +7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
Follow-up to CORE-1514 (deprecation note). Removes the "Allow Anonymous Write" feature entirely:
Accounts_AllowAnonymousWritesetting and its deprecation alertComposerAnonymousnow only offers sign in)registerUsermethod (no more user creation without email); method signature narrowed on server and@rocket.chat/ui-clienttypesanonymousrole: dropped from default permissions, role seeding and role priority order;runAfterVerifyEmail/ deprecatedafterVerifyEmailmethod removed (their only job was promoting anonymous users)Migration
v338:Accounts_AllowAnonymousWritesetting documentanonymousroleanonymousfrom every permission's role list and deletes the role documentAnonymous read (
Accounts_AllowAnonymousRead) is untouched. The$ne: 'anonymous'filters inUsers/Sessionsstats aggregations are kept on purpose since historical user/session documents still carry the role id.Issue(s)
https://rocketchat.atlassian.net/browse/CORE-1514
Steps to test or reproduce
Accounts_AllowAnonymousWriteenabled and at least one anonymous-role user, start the server on this branch.rocketchat_settingsno longer hasAccounts_AllowAnonymousWrite,rocketchat_roleshas noanonymousdoc, and no permission listsanonymous.active: falseand cannot resume its session.Accounts_AllowAnonymousRead, open a public channel logged out: composer only shows "Sign in to start talking".Further comments
Changeset marks
@rocket.chat/meteor,@rocket.chat/i18nand@rocket.chat/ui-clientas major.