Skip to content

Conversation

@MuhammadUmar7195
Copy link

Proposed changes (including videos or screenshots)

Refactor boolean logic in Options and OptionsPaginated components to improve code readability and type safety.

Screenshot from 2026-01-26 01-23-25

Issue(s)

#1824

Further comments

Changes Made:

  • Options.tsx: Replaced complex boolean logic with ternary expressions for selected and focus props
  • OptionsPaginated.tsx: Applied same refactoring for consistency
  • Removed unnecessary multiple dependency from useMemo hook in Options.tsx

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2026

⚠️ No Changeset found

Latest commit: 8a949e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2026

CLA assistant check
All committers have signed the CLA.

@MuhammadUmar7195 MuhammadUmar7195 changed the title Refactor boolean logic in Options components to use ternary expressions Refactor boolean logic in Options components to use ternary expressions #1824 Jan 26, 2026
@MuhammadUmar7195 MuhammadUmar7195 changed the title Refactor boolean logic in Options components to use ternary expressions #1824 refactor(fuselage): Improve boolean logic in Options components #1824 Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants