Skip to content

Conversation

@Anshumancanrock
Copy link

Fixed ButtonGroup RTL spacing by adding explicit [dir='rtl'] overrides for first and last child margins. The postcss-logical plugin was converting CSS logical properties to physical properties (margin-left/right) without generating proper RTL fallback rules, causing incorrect spacing in RTL layouts.

Closes #1851

Steps to test or reproduce

  1. Login to Rocket.Chat
  2. Change language to Arabic
  3. Navigate to Account → Preferences
  4. Scroll to the bottom and observe the Cancel and Save Changes buttons
  5. Verify proper spacing between buttons
  6. Switch back to English and verify LTR layout still looks good

Before fix:

Screenshot 2026-01-21 001110

After fix:

Screenshot 2026-01-20 225507
  • Bug Fixes

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2026

🦋 Changeset detected

Latest commit: 843bd49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/fuselage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent button spacing in RTL mode

3 participants