MNT: Remove Unused pylint Disable Statements. by phmbressan · Pull Request #1067 · RocketPy-Team/RocketPy

phmbressan · 2026-07-14T07:06:15Z

Pull request type

Code maintenance (refactoring, formatting, tests)

Checklist

Lint (make format && make lint) has passed locally
CHANGELOG.md has been updated (if relevant)

Breaking change

Yes
No

codecov · 2026-07-14T07:17:26Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.85%. Comparing base (4a67a41) to head (eaab13c).
⚠️ Report is 15 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1067      +/-   ##
===========================================
- Coverage    81.74%   80.85%   -0.89%     
===========================================
  Files          118      122       +4     
  Lines        15248    16355    +1107     
===========================================
+ Hits         12464    13224     +760     
- Misses        2784     3131     +347

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Gui-FernandesBR

Loved that!

- Fold the Unreleased section into v1.13.0 and date it 2026-07-19. - Drop reverted PR #958 entries (parachute abstract-base breaking change) and its revert #1063 - neither ever reached a release. - Consolidate the 3D flight animation into a single #1066 (PyVista) entry; drop the superseded Vedo-based #909. - Remove duplicate entries (#1066, #1067, #1055 in Added, #1047 in Added) and the doubled "ENH: ENH:" / "MNT: MNT:" auto-changelog prefixes. - Drop non-user-facing meta entries (#1062 changelog cleanup, #1069 CI fix) and the test-only entry (#1051), per the changelog's own scope rules. - Add the missing #1070 (max_time for StochasticFlight) entry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

… deps sync (#1073) * DOC: consolidate and clean v1.13.0 changelog for release - Fold the Unreleased section into v1.13.0 and date it 2026-07-19. - Drop reverted PR #958 entries (parachute abstract-base breaking change) and its revert #1063 - neither ever reached a release. - Consolidate the 3D flight animation into a single #1066 (PyVista) entry; drop the superseded Vedo-based #909. - Remove duplicate entries (#1066, #1067, #1055 in Added, #1047 in Added) and the doubled "ENH: ENH:" / "MNT: MNT:" auto-changelog prefixes. - Drop non-user-facing meta entries (#1062 changelog cleanup, #1069 CI fix) and the test-only entry (#1051), per the changelog's own scope rules. - Add the missing #1070 (max_time for StochasticFlight) entry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * MNT: sync optional animation deps in requirements-optional.txt The 3D flight animation switched from Vedo (#909) to PyVista (#1066). pyproject.toml was updated (animation extra = pyvista + imageio-ffmpeg) but requirements-optional.txt still pinned the now-unused vedo and was missing the new deps. Drop vedo and add pyvista/imageio-ffmpeg so both dependency sources agree. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* ENH: `Function` vectorized speed-up and refactor (#1049) * MNT: deduplicate function arithmetic logic. ENH: modularize function arithmetic and source dispatch. MNT: refactor function math modules. MNT: optimize function math speed. * MNT: enhance parachute trigger evaluation for speed. * MNT: improve typing stack on Function evaluation. * MNT: architecture corrections and optimizations. * TST: attempt at tests re-run. * MNT: minor fixes and docstring update. * DOC: Update Changelog for PR #1049 * ENH: Interactive 3D Flight Trajectory and Attitude Animation. (#1066) * ENH: Interactive 3D Flight Trajectory and Attitude Animation. * TST: update actions workflow dependencies for headless run. * MNT: solve plot animation review comments on styling. * DOC: Update Changelog for PR #1066 * MNT: Remove unused pylint disable statements. (#1067) * DOC: Update Changelog for PR #1067 * TST: cover PyVista flight animation helpers and fix docstring Fixes the two CI failures on the develop -> master sync (PR #1068): - DOC/build-docs: the ``color_by`` parameter of ``animate_trajectory`` used the numpydoc ``{...}`` value-set syntax split across two lines, which numpydoc rejects ("invalid value set (missing closing brace)"). Because the docs job builds with ``-W`` (warnings as errors) the build failed. Rewrite the type as a single-line prose description. - codecov/patch and codecov/project: the new PyVista animation subsystem in ``_FlightPlots`` was only exercised by a single minimal off-screen smoke test, leaving the scene builders and the pure geometry/telemetry helpers uncovered. Add unit tests for the render-independent helpers (quaternion rotation, polylines, camera paths, option validation, event markers, telemetry panels, background palette, etc.) and extend the off-screen integration tests to drive the full set of overlays (charts, camera tracking, stability markers, playback controls) and the GIF export path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VW2VidZmPd93dd8xW8BX2J * DOC: Update Changelog for PR #1069 * ENH: Add optional `max time` to `stochastic_flight` and create `stochastic_flight` objects with attributes in base flight (#1070) * Add max_time option to stochastic_flight * Update: use default attributes in flight object for stochastic flights * Add tests to check attributes * Refactor implementation * MNT: pre-release v1.13.0 cleanup — changelog consolidation + optional deps sync (#1073) * DOC: consolidate and clean v1.13.0 changelog for release - Fold the Unreleased section into v1.13.0 and date it 2026-07-19. - Drop reverted PR #958 entries (parachute abstract-base breaking change) and its revert #1063 - neither ever reached a release. - Consolidate the 3D flight animation into a single #1066 (PyVista) entry; drop the superseded Vedo-based #909. - Remove duplicate entries (#1066, #1067, #1055 in Added, #1047 in Added) and the doubled "ENH: ENH:" / "MNT: MNT:" auto-changelog prefixes. - Drop non-user-facing meta entries (#1062 changelog cleanup, #1069 CI fix) and the test-only entry (#1051), per the changelog's own scope rules. - Add the missing #1070 (max_time for StochasticFlight) entry. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * MNT: sync optional animation deps in requirements-optional.txt The 3D flight animation switched from Vedo (#909) to PyVista (#1066). pyproject.toml was updated (animation extra = pyvista + imageio-ffmpeg) but requirements-optional.txt still pinned the now-unused vedo and was missing the new deps. Drop vedo and add pyvista/imageio-ffmpeg so both dependency sources agree. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * DOC: Update Changelog for PR #1073 --------- Co-authored-by: Pedro Henrique Marinho Bressan <87212571+phmbressan@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: ZuoRen Chen <180084773+zuorenchen@users.noreply.github.com>

phmbressan added this to the Release v1.X.0 milestone Jul 14, 2026

phmbressan self-assigned this Jul 14, 2026

phmbressan requested a review from a team as a code owner July 14, 2026 07:06

phmbressan added the Refactor label Jul 14, 2026

Gui-FernandesBR reviewed Jul 14, 2026

View reviewed changes

Comment thread rocketpy/__init__.py

Gui-FernandesBR approved these changes Jul 14, 2026

View reviewed changes

MNT: Remove unused pylint disable statements.

eaab13c

phmbressan force-pushed the mnt/remove-unused-lint branch from 40d7555 to eaab13c Compare July 14, 2026 16:29

phmbressan merged commit be99259 into develop Jul 14, 2026
7 checks passed

phmbressan deleted the mnt/remove-unused-lint branch July 14, 2026 16:39

thc1006 pushed a commit to thc1006/RocketPy that referenced this pull request Jul 18, 2026

DOC: Update Changelog for PR RocketPy-Team#1067

064314e

Gui-FernandesBR mentioned this pull request Jul 19, 2026

MNT: pre-release v1.13.0 cleanup — changelog consolidation + optional deps sync #1073

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

MNT: Remove Unused pylint Disable Statements.#1067

MNT: Remove Unused pylint Disable Statements.#1067
phmbressan merged 1 commit into
developfrom
mnt/remove-unused-lint

phmbressan commented Jul 14, 2026

Uh oh!

codecov Bot commented Jul 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Gui-FernandesBR left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

phmbressan commented Jul 14, 2026

Pull request type

Checklist

Breaking change

Uh oh!

codecov Bot commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Gui-FernandesBR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Jul 14, 2026 •

edited

Loading