Open
Conversation
glemsom
commented
Aug 5, 2019
glemsom
commented
- Use specific Ubuntu version (as per Dockerfile best practice)
- Use version variable in Dockerfile
- Rework required gamefiles
- Consolidate volumes
- Add run script to create default gamefiles
Use Ubuntu bionic, 18.04
Adjust image to reflect this repo
As per Dockerfile best practice, remove apt-get cache after install
Owner
|
Thank you for the PR. The change to one volume is breaking, so that should be noted in the readme somewhere. Also there are some non-generic strings around, especially in the run script :) |
Owner
|
Bump |
Add missing executable-bit
fix chmod
fix path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.