-
Notifications
You must be signed in to change notification settings - Fork 11
Update date picker version and tweak layout logic #1105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for antenna-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for antenna-ssec ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThree UI changes: a dependency version bump for nova-ui-kit, an increased z-index in the page footer SCSS, and state/positioning adjustments to the date picker (popover placement, month state, and calendar props). Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DatePicker
participant Popover
participant Calendar
User->>DatePicker: click to open
DatePicker->>Popover: open()
Popover->>Calendar: render(month = DatePicker.month, captionLayout="dropdown")
User->>Calendar: change month / select date
Calendar->>DatePicker: onMonthChange(newMonth) / onSelect(date)
DatePicker->>DatePicker: update month, call onValueChange(selected)
User->>DatePicker: close popover
DatePicker->>DatePicker: effect resets month to selected
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Tip 🧪 Unit Test Generation v2 is now available!We have significantly improved our unit test generation capabilities. To enable: Add this to your reviews:
finishing_touches:
unit_tests:
enabled: trueTry it out by using the Have feedback? Share your thoughts on our Discord thread! Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Hey this works really well! I like the month & year pickers. Thanks @annavik. I tested in the collection form as well. One additional enhancement would be to open the calendar to the date that has already been selected. On my system if I select April 1, 1984, then open the calendar again it starts from Jan 2026.
|
Good point! Fixed ✅ |



Summary
Comment from @mihow :
In this PR we fix this by updating date picker version and the layout logic. The updated version (see separate PR) will allow year and month to be set from dropdown. This will make it a lot quicker if you want go back far in time. We also force the date picker to go below the trigger, to keep the position stable for navigation buttons. One little drawback is that scrolling will be needed, if there is not enough space below the trigger in the current view, to fit the calendar.
We also discussed setting the date from a text input. I had a quick look and that solution would require a bit more client side formatting with the current setup. I skipped for now since I think the fixes included will take care of the biggest problems.
Detailed Description
How to Test the Changes
Test interact with the date picker in the filter sidebar.
Screenshots
Before:

After:

Summary by CodeRabbit
Chores
Bug Fixes
✏️ Tip: You can customize this high-level summary in your review settings.