Skip to content

[Fix] Show callback URLs during source control setup - #1089

Merged
brunobergher merged 3 commits into
developfrom
improve/source-control-setup-parity-1vp10qc6od9co
Aug 5, 2026
Merged

[Fix] Show callback URLs during source control setup#1089
brunobergher merged 3 commits into
developfrom
improve/source-control-setup-parity-1vp10qc6od9co

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Created by Roomote. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Replaced the generic GitLab, Gitea, Bitbucket Cloud, and Azure DevOps setup copy in Settings with the same numbered, provider-specific setup structure used during onboarding.
  • Added each provider's exact callback or redirect URL beside its application-creation guidance and credential fields.
  • Kept configured-provider editing compact and preserved the existing GitHub App setup path.
  • Made shared callback URL rows use the available width and wrap full URLs on narrow screens instead of truncating them.

Why this change was made

The in-settings source-control setup flow omitted callback URLs and lacked the instruction-plus-details structure used by communications providers and onboarding. That left users without a critical value needed to create OAuth applications outside the initial setup flow.

Impact

Admins can now complete non-GitHub source-control application setup directly from Settings with provider-specific, copyable callback URLs and consistent numbered guidance on desktop and mobile.

Screenshots

GitLab shows numbered creation, callback URL, and credential steps

Gitea shows numbered creation, callback URL, and credential steps

Bitbucket Cloud shows OAuth scopes, callback URL, and credential steps

Azure DevOps shows delegated connection choices, permissions, callback URL, and the start of credential setup

GitLab keeps the numbered setup and full callback URL readable on mobile

@roomote-community

roomote-community Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

1 issue outstanding. See task

  • apps/web/src/components/settings/SourceControlConfigForm.tsx:135,288-303 The new settings-only default selects delegated Azure DevOps auth, but that mode disables Save until a linked account exists. The account-connect button is itself disabled until the app credentials have been saved (configured === true), so a first-time setup cannot save those credentials or start the Microsoft sign-in. Keep the initial save available before a linked account exists, as the onboarding flow does.
  • apps/web/src/app/api/source-control/gitlab/oauth/callback/route.ts:83-84, apps/web/src/app/api/source-control/gitea/oauth/callback/route.ts:82-83, apps/web/src/app/api/source-control/bitbucket/oauth/callback/route.ts:82-83 syncRepositoriesCommand returns { success: false } for expected sync failures, but these callbacks ignore that result and still redirect with provider=connected. Settings does not consume that status, so a failed initial sync leaves the admin with no error or retry guidance; handle the failed result before reporting success.
  • apps/web/src/components/settings/SourceControl.tsx:437-443 Saving a first-time delegated Azure DevOps setup now immediately calls the generic repository sync. Since no Microsoft account has been linked yet, delegated token resolution returns no token and Settings shows an erroneous ADO_TOKEN is required failure after the otherwise successful save. Do not sync until the account-link step completes (or start that link flow instead).

Reviewed c7c525f

@brunobergher
brunobergher marked this pull request as ready for review August 5, 2026 16:00
@brunobergher
brunobergher merged commit 7391c1b into develop Aug 5, 2026
18 checks passed
@brunobergher
brunobergher deleted the improve/source-control-setup-parity-1vp10qc6od9co branch August 5, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants