Skip to content

[Fix] Sidebar shows tasks owned by other users - #892

Merged
mrubens merged 1 commit into
developfrom
fix/sidebar-recent-tasks-2l3gs2hxxagbr
Jul 29, 2026
Merged

[Fix] Sidebar shows tasks owned by other users#892
mrubens merged 1 commit into
developfrom
fix/sidebar-recent-tasks-2l3gs2hxxagbr

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

Opened on behalf of Matt Rubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

Recent and pinned task IDs supplied to the sidebar search are now restricted to tasks initiated by the signed-in user. The DB-backed search regression test covers a mixed set of current-user and cross-user task IDs while preserving inclusion of the current user's pinned task.

Why this change was made

The normal sidebar search was user-scoped, but its explicit-ID fallback could return visible tasks initiated by other users. This made another user's task appear in recent sidebar results after its ID had been stored locally.

Impact

The web sidebar only shows tasks owned by the signed-in user, including when recent or pinned IDs are supplied. Cross-user task IDs are ignored by the server-side query.

@roomote-roomote

roomote-roomote Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

1 issue outstanding. See task

  • apps/web/src/lib/server/tasks.ts:521 Filtering includeIds by initiator hides existing cross-user pins. setTaskPinnedCommand explicitly allows every deployment member to pin any visible task, but pins are only removable from the sidebar; those hidden pins still consume the five-pin quota and cannot be unpinned.

Reviewed 6c48cb4

@mrubens
mrubens marked this pull request as ready for review July 29, 2026 22:31
@mrubens
mrubens merged commit cb1c049 into develop Jul 29, 2026
17 checks passed
@mrubens
mrubens deleted the fix/sidebar-recent-tasks-2l3gs2hxxagbr branch July 29, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant