Skip to content

ci: run CI on rc branch PRs and pushes - #68

Merged
chr1syy merged 1 commit into
rcfrom
fix/ci-trigger-rc
Jul 29, 2026
Merged

ci: run CI on rc branch PRs and pushes#68
chr1syy merged 1 commit into
rcfrom
fix/ci-trigger-rc

Conversation

@chr1syy

@chr1syy chr1syy commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Problem

.github/workflows/ci.yml only triggers on main:

on:
  pull_request:
    branches: [main]
  push:
    branches: [main]

So PRs targeting rc get no real CI run at all. CodeRabbit is the
only automation that fires, and it skips non-default branches — which
means an rc PR can look "green" while nothing has actually run tsc
or the test suite.

This bit us on #67 (inbound thread-session binding, including the
owner_user_id gate that fixed the session-hijack hole): it merged into
rc with zero CI checks, and the type-check + 579-test run had to be
reproduced by hand locally before merging.

Change

Add rc to both branch filters. One-line-per-trigger change, no job or
step edits — rc PRs and pushes now get the exact same npx tsc --noEmit + npm test gate as main.

Notes

  • No effect on main: its triggers are unchanged.
  • No new jobs, no new secrets, no runner-cost surprise beyond the rc
    PRs that should have been running all along.

🤖 Generated with Claude Code

PRs targeting `rc` currently get no real CI run — the workflow only
triggers on `main`, and CodeRabbit skips non-default branches. PR #67
(the inbound thread-session-binding feature, incl. the owner-gate
security fix) therefore merged into `rc` without a single CI check;
validation had to be done by hand locally.

Add `rc` to both the `pull_request` and `push` branch filters so the
release-candidate branch gets the same tsc + test gate as `main`.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8500830d-ee2d-47f4-ad7f-f11e5b0b0e2e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chr1syy
chr1syy merged commit ee7bd9e into rc Jul 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant