ci: run CI on rc branch PRs and pushes - #68
Merged
Merged
Conversation
PRs targeting `rc` currently get no real CI run — the workflow only triggers on `main`, and CodeRabbit skips non-default branches. PR #67 (the inbound thread-session-binding feature, incl. the owner-gate security fix) therefore merged into `rc` without a single CI check; validation had to be done by hand locally. Add `rc` to both the `pull_request` and `push` branch filters so the release-candidate branch gets the same tsc + test gate as `main`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.github/workflows/ci.ymlonly triggers onmain:So PRs targeting
rcget no real CI run at all. CodeRabbit is theonly automation that fires, and it skips non-default branches — which
means an
rcPR can look "green" while nothing has actually runtscor the test suite.
This bit us on #67 (inbound thread-session binding, including the
owner_user_idgate that fixed the session-hijack hole): it merged intorcwith zero CI checks, and the type-check + 579-test run had to bereproduced by hand locally before merging.
Change
Add
rcto both branch filters. One-line-per-trigger change, no job orstep edits —
rcPRs and pushes now get the exact samenpx tsc --noEmit+npm testgate asmain.Notes
main: its triggers are unchanged.rcPRs that should have been running all along.
🤖 Generated with Claude Code