refactor(workflow): S14 ProjectEngine merge queue deletion#1587
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7143d25 to
ffef184
Compare
264d113 to
25f4de6
Compare
Greptile SummaryThis draft stack-placeholder PR for S14 adds a plan doc and a static guard test asserting that
Confidence Score: 5/5Safe to merge as a draft placeholder; the guard test correctly verifies processor isolation today and the plan doc is accurate. Both changed files are non-production additions. The guard test passes against the current processor source with no logic or data-path changes introduced. The plan doc is informational only. No files require special attention beyond the single style note on the test's co-located assertion structure. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["workflow-merge-policy-deletion.test.ts"] -->|"readFileSync"| B["workflow-work-processor.ts"]
B -->|"positive: contains"| C["claimDueWorkflowWorkItem\nruntime.runWorkItem\n'merge' / 'manual-hold'"]
B -->|"negative: not contains"| D["mergeQueue\nenqueueMerge\nProjectEngine"]
E["project-engine.ts\n(59 legacy merge queue references)"] -.->|"not read by guard"| A
style E stroke-dasharray: 5 5
Reviews (9): Last reviewed commit: "test(FN-000): avoid freezing legacy merg..." | Re-trigger Greptile |
ffef184 to
1d5a02b
Compare
25f4de6 to
0636a71
Compare
1d5a02b to
1cc7876
Compare
0636a71 to
44b8d22
Compare
1cc7876 to
6dd457a
Compare
44b8d22 to
7dbdc6c
Compare
7dbdc6c to
f3a3eb5
Compare
5736ded to
5db1e17
Compare
b5661a3 to
f06dcb1
Compare
d47219e to
c232b1c
Compare
f06dcb1 to
68bd7d6
Compare
c232b1c to
63b1ee2
Compare
68bd7d6 to
34c9acc
Compare
63b1ee2 to
e331c28
Compare
34c9acc to
6616caf
Compare
Fusion-Task-Id: FN-000
e331c28 to
21ddf89
Compare
6616caf to
9a85540
Compare
Fusion-Task-Id: FN-000
Addressed: removed that legacy-state assertion. The guard now focuses on workflow processor isolation from |
|
Ready to review this PR? Stage has broken it down into 2 individual chapters for you:
Chapters generated by Stage for commit 91366fd on Jun 16, 2026 9:19am UTC. |
a5200a6
into
feature/workflow-owned-merge-s08-workflow-owned-merge-processing
Stack Slice
feature/workflow-owned-merge-s13-scheduler-policy-deletiondocs/plans/2026-06-09-003-refactor-workflow-owned-merge-full-migration-slices-plan.mdGoal
Remove production ProjectEngine merge queue policy and retain only explicit human/manual event entry points plus substrate helpers.
Dependency
S8 merge processing, S11 branch-group subgraphs, and S13 scheduler deletion.
Expected Scope
packages/engine/src/project-engine.ts; runtimes/in-process runtime; core store; merge lifecycle and deletion tests.
Expected Tests
No startup hidden enqueue, unpause wakes workflow work, manual merge event wakes merge node, stale mergeActive does not block workflow work, old queue APIs compatibility-only.
Exit Gate
No production caller starts merge processing outside workflow runtime.
Status
Draft stack placeholder. This PR reserves ordering and review context; implementation should replace or extend the handoff artifact before this slice is marked ready.
Implementation Added