refactor(workflow): S18 documentation settings and release notes#1591
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6e69a10 to
1c32f07
Compare
724670a to
254a3bf
Compare
Greptile SummaryThis PR delivers the S18 documentation layer for the workflow-owned merge migration stack, adding a runtime API reference document, glossary terms, an architecture patterns solutions doc, testing guidance, and a plan handoff artifact. All API surface names, state literals, and kind values in the new docs were verified against the source (
Confidence Score: 5/5Documentation-only changes with no runtime behavior modifications; safe to merge. All six changed files are pure documentation. The state literals, kind values, and API surface names in the new runtime reference doc were verified directly against packages/core/src/types.ts and the implementation files — every value matches. All cross-referenced solution docs and the full-plan file exist on disk. The one inaccuracy found (nodeId vs kind label in a single bullet point) has a suggestion attached and does not affect any runtime behavior. docs/workflow-owned-merge-runtime.md — one bullet mislabels the recovery-router nodeId as the work item kind (kind is recovery); a suggestion is attached. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph "Workflow-Owned Merge Runtime (documented in this PR)"
WI["workflow_work_items\n(runnable/running/held/retrying/\nmanual-required/succeeded/\nfailed/cancelled/exhausted)"]
CLAIM["claimDueWorkflowWorkItem\n(leases due work)"]
RUN["WorkflowTaskRuntime.runWorkItem\n(executes leased node)"]
MERGE["runWorkflowMergeAttemptNode\n(calls guarded merge primitive)"]
RECOVERY["publishWorkflowRecoveryEvent\n(self-healing facts to\nrecovery work item\nat recovery-router node)"]
PROJ_STATUS["projectWorkflowWorkStatus\n(workflow-first projection\nfor dashboard/API/CLI)"]
end
subgraph "Projection from Legacy"
PROJ_MR["TaskStore.projectMergeRequestToWorkflowWorkItem"]
HANDOFF["createCompletionHandoffWorkflowWork\n(merge-gate / merge-manual-hold)"]
end
subgraph "Cutover Guards"
G1["workflow-scheduler-policy-deletion.test.ts"]
G2["workflow-merge-policy-deletion.test.ts"]
G3["workflow-self-healing-policy-deletion.test.ts"]
G4["workflow-cutover-matrix.test.ts"]
end
PROJ_MR --> WI
HANDOFF --> WI
WI --> CLAIM
CLAIM --> RUN
RUN --> MERGE
RUN --> RECOVERY
RECOVERY --> WI
WI --> PROJ_STATUS
G1 -.->|guards against| WI
G2 -.->|guards against| MERGE
G3 -.->|guards against| RECOVERY
G4 -.->|cutover matrix| WI
Reviews (11): Last reviewed commit: "fix(FN-000): complete workflow stack ver..." | Re-trigger Greptile |
1c32f07 to
5fb5c9a
Compare
254a3bf to
f640883
Compare
5fb5c9a to
75a1709
Compare
f640883 to
399823f
Compare
75a1709 to
db51323
Compare
4252fe5 to
962767f
Compare
|
Addressed Greptile commit-message feedback by rewriting the S18 branch to a single compliant commit: |
962767f to
3b8a564
Compare
1fc96ee to
7beabf9
Compare
279059b to
9427fae
Compare
7beabf9 to
47bfa0e
Compare
Address PR #1591 feedback by separating workflow work item states from kinds in the runtime reference. The documented state list now matches WORKFLOW_WORK_ITEM_STATES, and recovery is documented as a kind. Note: pre-existing failure in pnpm test:gate at packages/engine/src/__tests__/self-healing.test.ts not addressed by this PR feedback fix.
Addressed: corrected |
Address PR #1591 feedback by separating workflow work item states from kinds in the runtime reference. The documented state list now matches WORKFLOW_WORK_ITEM_STATES, and recovery is documented as a kind. Note: pre-existing failure in pnpm test:gate at packages/engine/src/__tests__/self-healing.test.ts not addressed by this PR feedback fix.
47bfa0e to
e7391a5
Compare
Address PR #1591 feedback by including the scheduler deletion guard in the documented workflow-owned merge verification set.
895362d to
89bc786
Compare
Address PR #1591 feedback by separating workflow work item states from kinds in the runtime reference. The documented state list now matches WORKFLOW_WORK_ITEM_STATES, and recovery is documented as a kind. Note: pre-existing failure in pnpm test:gate at packages/engine/src/__tests__/self-healing.test.ts not addressed by this PR feedback fix.
Address PR #1591 feedback by including the scheduler deletion guard in the documented workflow-owned merge verification set.
89bc786 to
c5c011c
Compare
e7391a5 to
61c1924
Compare
Address PR #1591 feedback by separating workflow work item states from kinds in the runtime reference. The documented state list now matches WORKFLOW_WORK_ITEM_STATES, and recovery is documented as a kind. Note: pre-existing failure in pnpm test:gate at packages/engine/src/__tests__/self-healing.test.ts not addressed by this PR feedback fix.
61c1924 to
e7b76ff
Compare
Address PR #1591 feedback by including the scheduler deletion guard in the documented workflow-owned merge verification set.
c5c011c to
3a31499
Compare
Address PR #1591 feedback by separating workflow work item states from kinds in the runtime reference. The documented state list now matches WORKFLOW_WORK_ITEM_STATES, and recovery is documented as a kind. Note: pre-existing failure in pnpm test:gate at packages/engine/src/__tests__/self-healing.test.ts not addressed by this PR feedback fix.
Address PR #1591 feedback by including the scheduler deletion guard in the documented workflow-owned merge verification set.
3a31499 to
3a4a6a4
Compare
74624f9 to
51057f7
Compare
Address PR #1591 feedback by separating workflow work item states from kinds in the runtime reference. The documented state list now matches WORKFLOW_WORK_ITEM_STATES, and recovery is documented as a kind. Note: pre-existing failure in pnpm test:gate at packages/engine/src/__tests__/self-healing.test.ts not addressed by this PR feedback fix.
Address PR #1591 feedback by including the scheduler deletion guard in the documented workflow-owned merge verification set.
3a4a6a4 to
518ab1a
Compare
Fusion-Task-Id: FN-000
Capture the workflow-owned merge stack repair pattern learned from resolving review feedback across dependent PRs, including the earliest-branch fix and rebase-forward workflow.
Address PR #1591 feedback by separating workflow work item states from kinds in the runtime reference. The documented state list now matches WORKFLOW_WORK_ITEM_STATES, and recovery is documented as a kind. Note: pre-existing failure in pnpm test:gate at packages/engine/src/__tests__/self-healing.test.ts not addressed by this PR feedback fix.
Address PR #1591 feedback by including the scheduler deletion guard in the documented workflow-owned merge verification set.
51057f7 to
2ce9a9f
Compare
518ab1a to
ab59d72
Compare
|
Ready to review this PR? Stage has broken it down into 4 individual chapters for you: Chapters generated by Stage for commit ab59d72 on Jun 16, 2026 9:20am UTC. |
Stack Slice
feature/workflow-owned-merge-s17-cutover-matrixdocs/plans/2026-06-09-003-refactor-workflow-owned-merge-full-migration-slices-plan.mdGoal
Update architecture, settings, dashboard, CLI, and testing docs for workflow-owned policy and compatibility projections.
Dependency
S17 end-to-end cutover matrix.
Expected Scope
docs/architecture.md; docs/workflow-steps.md; docs/dashboard-guide.md; docs/settings-reference.md; docs/testing.md; CONCEPTS.md; changeset.
Expected Tests
Docs inventory/search tests where applicable; lazy view inventory unchanged unless dashboard imports change.
Exit Gate
User-facing docs use the same state names as API/UI tests, and a patch changeset exists if published behavior changed.
Status
Draft stack placeholder. This PR reserves ordering and review context; implementation should replace or extend the handoff artifact before this slice is marked ready.
Implementation Added