Skip to content

Added Draco Compression#311

Open
Sirsho1997 wants to merge 3 commits into
mainfrom
feature-draco-compression
Open

Added Draco Compression#311
Sirsho1997 wants to merge 3 commits into
mainfrom
feature-draco-compression

Conversation

@Sirsho1997

Copy link
Copy Markdown
Collaborator

Added

  • IDracoCompression dataclass for settings.dracoCompression:
    • enabled: Optional[bool]
    • level: Optional[int]
    • quantizationPosition: Optional[int]
    • quantizationNormal: Optional[int]
    • quantizationTexCoord: Optional[int]
  • ISettings now includes:
    • dracoCompression: Optional[Union[bool, IDracoCompression, Dict[str, Any]]]

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6348a781-f319-49ae-8dcf-f641fb9f0ca2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feature-draco-compression

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the SDK’s 3D inference settings model to support Draco mesh compression by introducing a dedicated IDracoCompression dataclass and wiring it into ISettings, so callers can pass either a boolean toggle or detailed compression parameters.

Changes:

  • Added IDracoCompression dataclass to represent settings.dracoCompression options.
  • Extended ISettings with dracoCompression and added dict-to-dataclass coercion in ISettings.__post_init__.
  • Added a debug print(json.dumps(...)) of the 3D request payload in _build3dRequest (this should be removed before merge).

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

File Description
runware/types.py Adds IDracoCompression and integrates dracoCompression into ISettings (including dict coercion).
runware/base.py Modifies 3D request building but currently introduces an unconditional stdout dump of the request payload.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants