Added Draco Compression#311
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches✨ Simplify code
Comment |
There was a problem hiding this comment.
Pull request overview
This PR extends the SDK’s 3D inference settings model to support Draco mesh compression by introducing a dedicated IDracoCompression dataclass and wiring it into ISettings, so callers can pass either a boolean toggle or detailed compression parameters.
Changes:
- Added
IDracoCompressiondataclass to representsettings.dracoCompressionoptions. - Extended
ISettingswithdracoCompressionand added dict-to-dataclass coercion inISettings.__post_init__. - Added a debug
print(json.dumps(...))of the 3D request payload in_build3dRequest(this should be removed before merge).
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| runware/types.py | Adds IDracoCompression and integrates dracoCompression into ISettings (including dict coercion). |
| runware/base.py | Modifies 3D request building but currently introduces an unconditional stdout dump of the request payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added
IDracoCompressiondataclass forsettings.dracoCompression:enabled: Optional[bool]level: Optional[int]quantizationPosition: Optional[int]quantizationNormal: Optional[int]quantizationTexCoord: Optional[int]ISettingsnow includes:dracoCompression: Optional[Union[bool, IDracoCompression, Dict[str, Any]]]