Remove ConstChoice::is_true_vartime
#1034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `to_bool_vartime` and `is_true_vartime` methods duplicate each other, performing the same function. I picked `to_bool_vartime` to consolidate on.
tarcieri
force-pushed
the
remove-constchoice-is-true-vartime
branch
from
152179e to
27f5e08
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1034 +/- ##
==========================================
- Coverage 79.23% 79.23% -0.01%
==========================================
Files 164 164
Lines 17710 17707 -3
==========================================
- Hits 14033 14030 -3
Misses 3677 3677 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
to_bool_vartimeandis_true_vartimemethods duplicate each other, performing the same function.I picked
to_bool_vartimeto consolidate on.