Impl and bound Integer on CtGt/CtLt
#1049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the previous bounds on `subtle::ConstantTimeGreater`
and `ConstantTimeLess` with `ctutils::{CtGt, CtLt}`.
The old `subtle` trait impls are retained but no longer used in bounds.
One step closer to making `subtle` optional.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1049 +/- ##
==========================================
- Coverage 79.14% 79.13% -0.01%
==========================================
Files 164 164
Lines 17540 17564 +24
==========================================
+ Hits 13882 13900 +18
- Misses 3658 3664 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tarcieri
force-pushed
the
ctutils-comparison-traits
branch
from
ae135b6 to
b3f2fa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the previous bounds on
subtle::ConstantTimeGreaterandConstantTimeLesswithctutils::{CtGt, CtLt}.The old
subtletrait impls are retained but no longer used in bounds. One step closer to makingsubtleoptional.