ed448-goldilocks: account for oddness in Scalar divisions - #1369
Merged
Conversation
55 tasks
tarcieri
reviewed
Aug 25, 2025
daxpedda
force-pushed
the
ed448-mul-opt-2
branch
3 times, most recently
from
September 2, 2025 13:00
55b2586 to
7baf0cb
Compare
Member
Contributor
Author
|
It requires #1335. The issue is that it messes with how scalar multiplication works, so the |
daxpedda
force-pushed
the
ed448-mul-opt-2
branch
from
September 2, 2025 20:25
7baf0cb to
54bba0b
Compare
daxpedda
marked this pull request as ready for review
September 2, 2025 20:25
tarcieri
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taking what I learned from dalek-cryptography/curve25519-dalek#805 I applied this to
ed448-goldilocksas well.This is based on #1335 because the current check for torsion-freeness multiplies by the order, which breaks most proper assumptions made here.