ed448-goldilocks: don't reduce points during decompression#1462
Open
daxpedda wants to merge 1 commit into
Open
ed448-goldilocks: don't reduce points during decompression#1462daxpedda wants to merge 1 commit into
ed448-goldilocks: don't reduce points during decompression#1462daxpedda wants to merge 1 commit into
Conversation
55 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 8032 specifies that points shouldn't be just reduced during de-serialization.
This PR changes
CompressedEdwardsY::decompress()to not reduce the point.Additionally,
CompressedDecaf::decompress()was reducing the point and then checking if the original point was reduced. The check if the point is reduced in the first place is much cheaper.Related: dalek-cryptography/curve25519-dalek#626.