[WIP] primefield: add "fused" ops to FieldExt#1840
Draft
tarcieri wants to merge 1 commit into
Draft
Conversation
Exploring what might make sense here. Starting with: - `add_mul`: (a + b) * c - `sub_mul`: (a - b) * c The only field backend where I've done an optimization for these is `p521`. Notably its multiply takes a `LooseFieldElement` so there is further potential for another add/sub operation in place of `c`, e.g. `(a + b) * (c + d)`. Before going any farther down this road it would be good to look at: - what works well for the `k256` field element implementation - what we could potentially add to `primefield::MontyFieldElement` in a generic implementation
This was referenced Jun 22, 2026
Member
Author
|
I'll note whether you do an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exploring what might make sense here. Starting with:
add_mul: (a + b) * csub_mul: (a - b) * cThe only field backend where I've done an optimization for these is
p521. Notably its multiply takes aLooseFieldElementso there is further potential for another add/sub operation in place ofc, e.g.(a + b) * (c + d).Before going any farther down this road it would be good to look at:
k256field element implementationprimefield::MontyFieldElementin a generic implementation