Remove unused base64, bigdecimal and ostruct dependencies#91
Merged
Rykian merged 2 commits intoRykian:masterfrom Feb 28, 2026
Merged
Remove unused base64, bigdecimal and ostruct dependencies#91Rykian merged 2 commits intoRykian:masterfrom
Rykian merged 2 commits intoRykian:masterfrom
Conversation
Running the test suite without the ostruct dependency triggers the following warning but its not a dependency for the gem, it's only needed in development or test. ``` /Users/j.julio/Projects/clockwork/test/database_events/event_store_test.rb:4: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 4.0.0. ``` Any app installing the clockwork gem should not be pulling ostruct for that matter.
These 3 dependencies were added in this commit Rykian@4f0d4a7#diff-c9a7ef3318660ff5cc0c9a572754eede8729f9b464e163638ff6f0c5366458c3 but they are not necessary for the gem to run. The only one that outputs a warning is ostruct but we only need to install that for gem development and test. An app that has a clockwork dependency should NOT be pulling any of these dependencies.
Author
|
@Rykian hello again. 👋🏻 Thank you for the v4 release. The DST fix will be helpful as we've been dealing with that for a long time but didn't know the cause. I noticed these dependencies were added in v4 but they are not needed and should be avoided as an app that depends on clockwork should not be pulling these in. Would you accept this change and cut a new release? I've opened some other PRs to help improve maintenance as well. Thank you again. |
Owner
|
Thanks for noticing this, I don't remember why I added these. Maybe because old activesupport versions were requiring it. |
Author
|
@Rykian no worries and thank you again! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These 3 dependencies were added in this commit but they are unnecessary since the gem has no
Base64,BigDecimalorOpenStructreferences in user facing code. Once removed, onlyostructoutputs a warning but that dependency is only needed in the test suite. An app that has a clockwork dependency should NOT be pulling in any of these dependencies.