Skip to content

Sarah/add location metadata #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
skeating wants to merge 10 commits into from
Closed

Sarah/add location metadata #121

skeating wants to merge 10 commits into from

Conversation

@skeating
Copy link
Contributor

@skeating skeating commented Oct 19, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 19, 2025

PR checklist

Default guide for a PR (if multiple PRs for the work, only keep one version of it and link to it on the other PRs)

  • From the UCLH data science desktop, a validation run has been set off
  • Check that content that reveals Epic IP (eg. Clarity/Caboodle queries) has not been checked into a public repo.
  • load times
    in UCL teams has been populated with the run information
  • During the run, glowroot has been checked for any queries which are taking a substantial proportion of the
    total processing time. This can be useful to identify indexes that are required.
  • After the run, look for any unexpected errors in the etl_per_message_logging table, the error_search.sql file
    on the shared drive can be used for this \\sharefs6\UCLH6\EMAP\Shared\EmapSqlScripts\devops\error_search.sql.
    Create an issue if you find an unexpected exception and is not related to the changes you've made, otherwise
    fix them!
  • After the run, populate the end time in
    load times
  • Let Aasiyah know about the completed validation and give her information on the changes and where to start
    with the validation
  • Check validation report and give any feedback to Aasiyah if there are any changes needed on her side,
    iterate on getting the validation to match at least 99% (validation and emap code).

@skeating skeating marked this pull request as ready for review October 19, 2025 13:30
stefpiatek
stefpiatek approved these changes Oct 20, 2025
View reviewed changes
emap-star/emap-star/src/main/java/uk/ac/ucl/rits/inform/informdb/movement/DepartmentState.java Outdated
Comment on lines 90 to 92
this.rptGrpNine = rptGrpNine;
this.isWardOrFlowArea = isWardOrFlowArea;
this.isCoreInpatientArea = isCoreInpatientArea;
Copy link
Collaborator

@stefpiatek stefpiatek Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can any of these change over time?

Copy link
Contributor Author

@skeating skeating Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking with Zella

@thompson318 thompson318 mentioned this pull request Oct 20, 2025
Open
@skeating
Adds site location to department metadata
016c315 
Adds site location information to the Department table
to allow for easier querying of locations.

Renames rptGrpNine to departmentType.

Populates the site location based on sending facility in
HL7 messages.
@skeating
fix linting
d9ed94f
@skeating
missed the capitalization form
6bdf74c
@skeating
update all the comparison messages to include site location
0aefbf6
@skeating
no I didn't check they are all UCLH
4eff55f
@skeating skeating closed this Oct 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefpiatek stefpiatek stefpiatek approved these changes

@thompson318 thompson318 Awaiting requested review from thompson318

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skeating @stefpiatek