Skip to content

Sk/add location metadata #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
skeating wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

Sk/add location metadata #122

skeating wants to merge 19 commits into from

Conversation

@skeating
Copy link
Contributor

@skeating skeating commented Oct 25, 2025

it takes out site location taken from the HL7 messages and assumes it will be hoovered

skeating added 15 commits October 19, 2025 12:56
@skeating
add new variables
d69046f
@skeating
change check style to allow more than seven arguments to a function
80ff91d
@skeating
Add the variables to the metadata class
ffd29fe
@skeating
fix the location controller to reflect the new metadata values
ad22070
@skeating
files for testing hoover
32f117e
@skeating
Adds site location to department metadata
016c315 
Adds site location information to the Department table
to allow for easier querying of locations.

Renames rptGrpNine to departmentType.

Populates the site location based on sending facility in
HL7 messages.
@skeating
fix linting
d9ed94f
@skeating
missed the capitalization form
6bdf74c
@skeating
update all the comparison messages to include site location
0aefbf6
@skeating
no I didn't check they are all UCLH
4eff55f
@skeating
Revert "no I didn't check they are all UCLH"
f25f2bb 
This reverts commit 4eff55f.
@skeating
Revert "update all the comparison messages to include site location"
e159567 
This reverts commit 0aefbf6.
@skeating
take out the site location variable
baaaa0a
@skeating
add site location as metadata to be red by the hoover
d60ad27
@skeating
fix check style
9492f6e
@github-actions
Copy link

github-actions bot commented Oct 25, 2025

PR checklist

Default guide for a PR (if multiple PRs for the work, only keep one version of it and link to it on the other PRs)

  • From the UCLH data science desktop, a validation run has been set off
  • Check that content that reveals Epic IP (eg. Clarity/Caboodle queries) has not been checked into a public repo.
  • load times
    in UCL teams has been populated with the run information
  • During the run, glowroot has been checked for any queries which are taking a substantial proportion of the
    total processing time. This can be useful to identify indexes that are required.
  • After the run, look for any unexpected errors in the etl_per_message_logging table, the error_search.sql file
    on the shared drive can be used for this \\sharefs6\UCLH6\EMAP\Shared\EmapSqlScripts\devops\error_search.sql.
    Create an issue if you find an unexpected exception and is not related to the changes you've made, otherwise
    fix them!
  • After the run, populate the end time in
    load times
  • Let Aasiyah know about the completed validation and give her information on the changes and where to start
    with the validation
  • Check validation report and give any feedback to Aasiyah if there are any changes needed on her side,
    iterate on getting the validation to match at least 99% (validation and emap code).

@skeating skeating marked this pull request as ready for review October 25, 2025 13:49
@skeating skeating requested a review from stefpiatek October 25, 2025 13:49
@skeating
Copy link
Contributor Author

skeating commented Oct 30, 2025

NOTE THIS HAS BEEN MERGED INTO test_branch_zella

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stefpiatek stefpiatek Awaiting requested review from stefpiatek

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skeating @stefpiatek