fix: publish window entities as binary_sensors instead of switches#435
Merged
nanomad merged 3 commits intoSAIC-iSmart-API:developfrom Mar 14, 2026
Merged
Conversation
…AIC-iSmart-API#252) Window entities were exposed as switches in HA discovery but had no command handlers, causing errors when toggled. Change them to binary_sensors with device_class=window. Old switch discovery entries are unpublished on startup to provide a clean migration path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add missing device_class="window" to sunroof binary_sensor - Make test assertions unconditional (no silent pass on regression) - Add payload verification to sunroof supported test - Verify sunroof switch is always unpublished Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
switchtobinary_sensorwithdevice_class=window, since remote window control is not implemented and toggling the switches caused errorsCloses #252
Test plan
switch.window_*entities and createsbinary_sensor.window_*entities after gateway restart🤖 Generated with Claude Code