Skip to content

Showcase health-check-interval in cf-app example#122

Open
IvanBorislavovDimitrov wants to merge 1 commit into
SAP-samples:mainfrom
IvanBorislavovDimitrov:feature/LMCROSSITXSADEPLOY-3316-v2
Open

Showcase health-check-interval in cf-app example#122
IvanBorislavovDimitrov wants to merge 1 commit into
SAP-samples:mainfrom
IvanBorislavovDimitrov:feature/LMCROSSITXSADEPLOY-3316-v2

Conversation

@IvanBorislavovDimitrov

Copy link
Copy Markdown
Member

Summary

Adds the module-level MTA parameter health-check-interval to the canonical cf-app example, so users can see how to configure how often Cloud Foundry runs the liveness check alongside the existing health-check-* parameters.

The new line is inserted directly after health-check-timeout: 180 #seconds in both descriptors, with a trailing comment explaining its purpose.

Changes

  • cf-app/mta.yaml — development descriptor: add health-check-interval next to the existing health-check parameters.
  • cf-app/mtad.yaml — deployment descriptor: same addition for parity.

Two lines added in total; no other changes.

Background

health-check-interval is an integer (seconds, optional) that controls how often Cloud Foundry runs the configured liveness check on an application instance. It became expressible through the MTA model after the underlying CF Java client adoption in the deploy service was refreshed; this example documents the canonical placement for end users.

Acceptance criteria

Per the linked Jira: a user should be able to deploy the cf-app example with health-check-interval configured and observe the liveness probe running at the requested cadence. The example file alone covers the documentation half of that scenario.

Relation to existing PR #115

This is an alternative to #115, which targets the same Jira key (LMCROSSITXSADEPLOY-3316) with a substantively similar change. Opened at the user's request so reviewers can compare both proposals and merge whichever is preferred; the other PR can then be closed.

JIRA: LMCROSSITXSADEPLOY-3316

Add health-check-interval next to the existing health-check-* parameters
in both mta.yaml and mtad.yaml of the canonical cf-app example, so users
can see how to configure the liveness probe frequency.

JIRA:LMCROSSITXSADEPLOY-3316
@IvanBorislavovDimitrov

Copy link
Copy Markdown
Member Author

MTA Quality Report — SAP-samples/cf-mta-examples PR #122

Jira: LMCROSSITXSADEPLOY-3316 — Introduce Health check interval
Backlog alignment: PASS

  • Implements Jira scope? yes — adds the exact health-check-interval parameter from the Jira's code sample to the canonical cf-app example, in both mta.yaml and mtad.yaml.
  • Changes outside Jira scope? no — only two identical lines added inside the existing parameters block, alongside the other health-check-* keys.

Code Review

⚠️ Subagent failed: code-reviewer subagent could not be spawned in this environment (no Task tool available to the orchestrator). The diff is two identical YAML lines (health-check-interval: 15 #seconds; how often CF runs the liveness check) added to cf-app/mta.yaml and cf-app/mtad.yaml — please review manually.


Security

⚠️ Subagent failed: security-reviewer subagent could not be spawned in this environment (no Task tool available to the orchestrator). Note for manual review: the change is purely declarative MTA YAML (a non-secret integer parameter); no credentials, URLs, or executable code are introduced.


SonarCloud

No SonarCloud check run found for this PR.


Dependency CVEs

✅ No new CVEs — this PR does not modify any dependency files (pom.xml, build.gradle, lockfiles).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant