Skip to content

fix: [DevOps] Update outdated DeploymentTest #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CharlesDuboisSAP wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: [DevOps] Update outdated DeploymentTest #750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/DeploymentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,33 @@

import static org.assertj.core.api.Assertions.assertThat;

import com.sap.ai.sdk.core.client.ConfigurationApi;
import com.sap.ai.sdk.core.model.AiConfigurationBaseData;
import com.sap.ai.sdk.core.model.AiDeployment;
import com.sap.ai.sdk.core.model.AiDeploymentStatus;
import com.sap.ai.sdk.foundationmodels.openai.OpenAiModel;
import org.junit.jupiter.api.Test;

class DeploymentTest {
/** Java end-to-end test specific configuration ID. "name":"config-java-e2e-test" */
public static final String CONFIG_ID = "67e8d039-c7f1-4179-9f8f-60d158a36b0e";
/** Java end-to-end test specific configuration ID. "name":"config-java-e2e-test-gpt-5" */
public static final String CONFIG_ID = "9db691a2-a136-41c9-8fe1-1ffad5a63594";

/**
* Manual execution to create a new config for a new model when the current model gets deprecated.
*/
// @Test
void createConfiguration() {
Comment on lines +16 to +20
Copy link
Member

@Jonas-Isr Jonas-Isr Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it more explicit:

Suggested change
/**
* Manual execution to create a new config for a new model when the current model gets deprecated.
*/
// @Test
void createConfiguration() {
/**
* Manual execution to create a new config for a new model when the current model gets deprecated.
* 1) Run the below method with a non-deprecated model.
* 2) Copy the printed ID into CONFIG_ID above.
*/
void createConfiguration() {

String modelToDeploy = OpenAiModel.GPT_5.name();
var response =
new ConfigurationApi()
.create(
"default",
AiConfigurationBaseData.create()
.name("config-java-e2e-test-" + modelToDeploy)
.executableId("azure-openai")
.scenarioId("foundation-models"));
System.out.println("Created configuration with ID: " + response.getId());
}

@Test
void createDelete() {
Expand Down