chore: Enhance HttpClient5 Retry-Strategy for 429 and 503 responses#1009
Open
chore: Enhance HttpClient5 Retry-Strategy for 429 and 503 responses#1009
Conversation
newtork
commented
Nov 18, 2025
.../main/java/com/sap/cloud/sdk/cloudplatform/connectivity/DefaultApacheHttpClient5Factory.java
Outdated
Show resolved
Hide resolved
MatKuhr
reviewed
Nov 20, 2025
| if( retry ) { | ||
| final String msg = | ||
| "Retrying {} request for destination {} to {} due to exception \"{}\". Retry attempt #{}."; | ||
| log.debug(msg, req.getMethod(), destination, req.getRequestUri(), exception.getMessage(), execCount); |
Member
There was a problem hiding this comment.
should be at least warn, maybe even error
Suggested change
| log.debug(msg, req.getMethod(), destination, req.getRequestUri(), exception.getMessage(), execCount); | |
| log.warn(msg, req.getMethod(), destination, req.getRequestUri(), exception.getMessage(), execCount); |
MatKuhr
reviewed
Nov 20, 2025
| final boolean retry = super.retryRequest(req, exception, execCount, context); | ||
| if( retry ) { | ||
| final String msg = | ||
| "Retrying {} request for destination {} to {} due to exception \"{}\". Retry attempt #{}."; |
Member
There was a problem hiding this comment.
Suggested change
| "Retrying {} request for destination {} to {} due to exception \"{}\". Retry attempt #{}."; | |
| "Retrying {} request to {} due to exception \"{}\". Retry attempt #{}."; |
since destination can be null and may not add much information if the URL is absolute (is it?). Alternatively, explicit null check to avoid strange looking log?
MatKuhr
reviewed
Nov 20, 2025
Member
MatKuhr
left a comment
There was a problem hiding this comment.
is there a way to print out the wait duration?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Related #1004
Log message written to
debug: