Transparent proxy: TP Loader Cloud SDK native integration#981
Merged
Transparent proxy: TP Loader Cloud SDK native integration#981
Conversation
|
|
VladislavAtanasov95
force-pushed
the
tploader
branch
7 times, most recently
from
b860033 to
cb21b31
Compare
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
KNikovv
reviewed
Oct 23, 2025
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
...rvice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoader.java
Outdated
Show resolved
Hide resolved
...e/src/test/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxyLoaderTest.java
Show resolved
Hide resolved
VladislavAtanasov95
force-pushed
the
tploader
branch
11 times, most recently
from
bc1d50c to
f7ee4bd
Compare
Contributor
Author
|
@MatKuhr please review |
VladislavAtanasov95
force-pushed
the
tploader
branch
2 times, most recently
from
72dc4c1 to
70ee9ae
Compare
...vice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/DefaultNetworkValidator.java
Outdated
Show resolved
Hide resolved
VladislavAtanasov95
force-pushed
the
tploader
branch
2 times, most recently
from
18db618 to
de06843
Compare
MatKuhr
reviewed
Nov 19, 2025
Member
MatKuhr
left a comment
MatKuhr
left a comment
There was a problem hiding this comment.
overall approach looks good! Haven't looked at tests yet. The only essential question for me is, if we can/should perform an actual call to TP already during tryGetDestination.
...vice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/DefaultNetworkValidator.java
Outdated
Show resolved
Hide resolved
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/NetworkValidator.java
Outdated
Show resolved
Hide resolved
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Show resolved
Hide resolved
...vice/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/DefaultNetworkValidator.java
Show resolved
Hide resolved
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Outdated
Show resolved
Hide resolved
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Outdated
Show resolved
Hide resolved
VladislavAtanasov95
force-pushed
the
tploader
branch
2 times, most recently
from
1f09efa to
dd731b9
Compare
VladislavAtanasov95
force-pushed
the
tploader
branch
4 times, most recently
from
524ab93 to
71ed5f5
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Fixed
Show fixed
Hide fixed
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Fixed
Show fixed
Hide fixed
VladislavAtanasov95
force-pushed
the
tploader
branch
from
71ed5f5 to
097abd4
Compare
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Fixed
Show fixed
Hide fixed
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Fixed
Show fixed
Hide fixed
MatKuhr
reviewed
Dec 3, 2025
...tion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/NetworkVerifier.java
Outdated
Show resolved
Hide resolved
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Outdated
Show resolved
Hide resolved
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Outdated
Show resolved
Hide resolved
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Show resolved
Hide resolved
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Show resolved
Hide resolved
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Outdated
Show resolved
Hide resolved
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Show resolved
Hide resolved
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Outdated
Show resolved
Hide resolved
VladislavAtanasov95
force-pushed
the
tploader
branch
8 times, most recently
from
1f74bb8 to
35ad515
Compare
MatKuhr
reviewed
Dec 17, 2025
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Outdated
Show resolved
Hide resolved
MatKuhr
previously approved these changes
Dec 17, 2025
Member
MatKuhr
left a comment
MatKuhr
left a comment
There was a problem hiding this comment.
Looks good from my side 👍
Thanks for all the work on this, I think we have a solid solution now and can improve it in the future as well e.g. with more features
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Outdated
Show resolved
Hide resolved
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Show resolved
Hide resolved
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Show resolved
Hide resolved
...ion-service/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/TransparentProxy.java
Show resolved
Hide resolved
VladislavAtanasov95
force-pushed
the
tploader
branch
2 times, most recently
from
1916fc7 to
84f972b
Compare
VladislavAtanasov95
force-pushed
the
tploader
branch
from
84f972b to
d5a1a3e
Compare
MatKuhr
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces native Cloud SDK integration for the Transparent Proxy (TP) loader, enabling seamless routing of destination requests through a single registered gateway host. This implementation provides a DestinationLoader that intercepts destination lookups and routes them through a configured proxy gateway.