feat: support provider:client for IAS app-to-app#986
Merged
CharlesDuboisSAP merged 2 commits intoSAP:mainfrom Oct 30, 2025
Merged
feat: support provider:client for IAS app-to-app#986CharlesDuboisSAP merged 2 commits intoSAP:mainfrom
CharlesDuboisSAP merged 2 commits intoSAP:mainfrom
Conversation
newtork
reviewed
Oct 28, 2025
...nnectivity/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/BtpServiceOptions.java
Show resolved
Hide resolved
MatKuhr
reviewed
Oct 28, 2025
Comment on lines
+647
to
+649
| "urn:sap:identity:application:provider:clientid:provider-client-id:apptid:provider-tenant-id", | ||
| "app_tid", | ||
| PROVIDER_TENANT_ID)); |
Member
There was a problem hiding this comment.
Unfortunately, the term provider is ambiguous in this context, and it becomes pretty apparent here 😅
- In the context of Cloud SDK, provider typically means the BTP subaccount in which this currently running Java application is hosted, i.e. the provider tenant
- In the context of IAS App2App, provider refers to the target system that is providing the API, and the currently running Java application acts as the consumer
I don't see an easy way to resolve this confusion, other than adding an explicit comment here that the difference apptid:provider-tenant-id vs. app_tid=PROVIDER_TENANT_ID is expected and intended.
MatKuhr
approved these changes
Oct 28, 2025
Member
MatKuhr
left a comment
MatKuhr
left a comment
There was a problem hiding this comment.
LGTM, ty for contributing 🥳
Adding a small release note would be good, but we can also do that in a separate PR to accelerate merging this. @newtork would leave that up to you depending on when we want to press the release button 😉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
SAP/cloud-sdk-java-backlog#ISSUENUMBER.
Add support for the
resource=urn:sap:identity:application:provider:clientid:resource definition for app2app token requests to reduce the number of required tokens from one per app2app "Dependency Name" to one per provider applicationFeature scope:
resource=urn:sap:identity:application:provider:clientid:<client-id-provider>:apptid:<tenant-id-provider>for app2app token reuests - ref Exposing APIs (SAP-internal)Definition of Done
Error handling created / updated & covered by the tests aboveRelease notes updated