chore(deps): Bump @sap/xssec from 4.12.1 to 4.12.2#6277
chore(deps): Bump @sap/xssec from 4.12.1 to 4.12.2#6277davidkna-sap wants to merge 2 commits intomainfrom
Conversation
davidkna-sap
changed the title
davidkna-sap
force-pushed
the
davidkna-sap_xssec-4.12.2
branch
from
8322890 to
9d85293
Compare
KavithaSiva
left a comment
KavithaSiva
left a comment
There was a problem hiding this comment.
I want to be sure of the changes from xssec, if this update is not critical can we release without this update instead?
| } from '@sap-cloud-sdk/connectivity/internal'; | ||
| import type { ServiceCredentials } from '@sap-cloud-sdk/connectivity'; | ||
|
|
||
| export function mockClientCredentialsGrantCall( |
There was a problem hiding this comment.
[q] I see that only the Client credentials call with client secret being supplied was changed.
I wonder why this does not affect the client credentials call with certificate or the user token grant call.
There was a problem hiding this comment.
From the release notes, it looks like all token retrieval flows are affected.
| '@sap-cloud-sdk/connectivity': minor | ||
| --- | ||
|
|
||
| [Compatibility Note] Update `@sap/xssec` to version 4.12.2 with changed XSUAA URL behavior. |
There was a problem hiding this comment.
[q] I did not manage to find any release notes for the change from xssec.
As the behaviour seems a bit inconsistent(see below), would be nice to cite any documentation from their side.
There was a problem hiding this comment.
Bumps @sap/xssec from 4.12.1 to 4.12.2. --- updated-dependencies: - dependency-name: "@sap/xssec" dependency-version: 4.12.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
davidkna-sap
force-pushed
the
davidkna-sap_xssec-4.12.2
branch
from
9d85293 to
fa9e406
Compare
davidkna-sap
force-pushed
the
davidkna-sap_xssec-4.12.2
branch
from
fa9e406 to
62add37
Compare
2 participants
Closes SAP/cloud-sdk-backlog#ISSUENUMBER.
This PR bumps @sap/xssec from 4.12.1 to 4.12.2, fixes tests and adds a changeset.