Merged
Conversation
davidkna-sap
force-pushed
the
davidkna-sap_js-docs-ias
branch
from
3ef293c to
7233daa
Compare
davidkna-sap
force-pushed
the
davidkna-sap_js-docs-ias
branch
from
372317e to
e3bdb6a
Compare
* origin/main: Bump prettier-plugin-java from 2.7.7 to 2.8.0 (#2349) Java 5.25.0: Add docu for TP loader (#2290) Bump dependabot/fetch-metadata from 2.4.0 to 2.5.0 (#2348) Bump @typescript-eslint/eslint-plugin from 8.51.0 to 8.52.0 (#2346) Bump prettier from 3.5.3 to 3.7.4 (#2324) Update SAP Cloud SDK for JavaScript API documentation update release notes (#2343) Update SAP Cloud SDK for JavaScript API documentation Bump globals from 16.5.0 to 17.0.0 (#2342) Bump @typescript-eslint/eslint-plugin from 8.50.1 to 8.51.0 (#2341) Bump @typescript-eslint/parser from 8.50.1 to 8.51.0 (#2340) Bump @typescript-eslint/eslint-plugin from 8.50.0 to 8.50.1 (#2339) Bump @typescript-eslint/parser from 8.50.0 to 8.50.1 (#2338) chore: Update JavaDocs for release 5.25.0 (#2337) Java: Add release notes for release 5.25.0 (#2336)
davidkna-sap
force-pushed
the
davidkna-sap_js-docs-ias
branch
from
4a949fc to
ff463a9
Compare
davidkna-sap
force-pushed
the
davidkna-sap_js-docs-ias
branch
from
ff463a9 to
e95931a
Compare
davidkna-sap
force-pushed
the
davidkna-sap_js-docs-ias
branch
from
1f199e2 to
d32e6b0
Compare
KavithaSiva
requested changes
Jan 28, 2026
Co-authored-by: KavithaSiva <kavitha.sivakumar@sap.com>
KavithaSiva
requested changes
Jan 28, 2026
Contributor
KavithaSiva
left a comment
KavithaSiva
left a comment
There was a problem hiding this comment.
Few more comments. Like I stated below, I cross-checked Java's implementation and confirmed that the subdomain replacement happens for both client credentials and jwt bearer flows if the subdomain information can be determined.
Co-authored-by: KavithaSiva <kavitha.sivakumar@sap.com>
Co-authored-by: KavithaSiva <kavitha.sivakumar@sap.com>
Member
Author
|
@KavithaSiva Good catch! I'll write a quick PR for cloud-sdk-js to change that. |
KavithaSiva
approved these changes
Jan 29, 2026
Contributor
KavithaSiva
left a comment
KavithaSiva
left a comment
There was a problem hiding this comment.
LGTM, added a minor comment. You can merge this after release.
|
|
||
| #### JWT-Based Tenant Extraction | ||
|
|
||
| When a JWT is supplied in the `options`, the SAP Cloud SDK automatically extracts the tenant information from the JWT assertion and routes token requests to the correct IAS tenant: |
Contributor
There was a problem hiding this comment.
[minor] Indicate that this works for both Business and Technical user authentication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Has Changed?
Explain what you are changing and why, if it isn't obvious from the diff.