align math with sa2 #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaceCear
reviewed
Jan 13, 2026
src/game/math.c
Outdated
| // TODO: match this | ||
| NONMATCH("asm/non_matching/game/math/sa2__sub_8084B54.inc", void sa2__sub_8084B54(struct UNK_8085F1C_1 *a, u16 b, u16 c, u16 d)) { } | ||
| END_NONMATCH | ||
| void sa2__sub_8084B54(struct UNK_8085F1C_1 *matrix, u16 anglez, u16 angley, u16 anglex) |
Contributor
There was a problem hiding this comment.
Please use the SA2_LABEL macro instead of sa2__ in the function headers.
But otherwise this is great, thanks! :D
Contributor
Author
There was a problem hiding this comment.
I can do, though it wasn't using the macro before ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.