Add CRT-PMT flash classification to TPC-PMT flash-matching producer #179
+10
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2025
PetrilloAtWork
requested changes
Jan 6, 2026
Member
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
There was a problem hiding this comment.
Request to add a pointer to how to decode the new value, and then auto-approved.
| float flashAsymmetry { kSignalingNaN }; ///< East-West asymmetry of PEs in matched flash | ||
| SRVector3D flashCenter; ///< Weighted mean ophit position in X,Y,Z [no meaingful X info for ophits] (cm) | ||
| SRVector3D flashWidth; ///< Weighted standard devitation of ophit position in X,Y,Z [no meaingful X info for ophits] (cm) | ||
| int flashClassification { kUninitializedInt }; ///< Flash classification according to the CRT-PMT matching |
Member
There was a problem hiding this comment.
Can you add a reference to how to decode it? E.g.:
Suggested change
| int flashClassification { kUninitializedInt }; ///< Flash classification according to the CRT-PMT matching | |
| int flashClassification { kUninitializedInt }; ///< Flash classification according to the CRT-PMT matching (`sbn::crt::MatchType`) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (based off of
v10_00_00) adds the flash classification from the CRT-PMT matching information to the best-matched flash in the TPC-PMT barycenter flash-matching producer.Associated PRs
Review
Tagging for review @francescopoppi and @PetrilloAtWork as the CRT & light gurus. Thanks!
Quick checklist
git fetchand pulled the latest changes from the branch you're basing your PR against? Will do, based on review.ClassVersionby one compared to develop in classes_def.xml?