Skip to content

Resolve #2487 - Auto subset size in grooming should pick a smart auto #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akenmorris merged 1 commit into from
Feb 5, 2026
Merged

Resolve #2487 - Auto subset size in grooming should pick a smart auto #2488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libs/Groom/Groom.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ bool Groom::run_alignment() {
bool any_alignment = false;

int reference_index = -1;
int subset_size = -1;
int subset_size = base_params.get_alignment_subset_size();

// per-domain alignment
for (size_t domain = 0; domain < num_domains; domain++) {
Expand Down
4 changes: 4 additions & 0 deletions Libs/Mesh/MeshUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@ PhysicalRegion MeshUtils::boundingBox(const std::vector<Mesh>& meshes, bool cent
}

int MeshUtils::findReferenceMesh(std::vector<Mesh>& meshes, int random_subset_size) {
// auto (-1) defaults to a subset of 30 to avoid O(n^2) pairwise ICP on large datasets
if (random_subset_size < 0) {
random_subset_size = 30;
}
bool use_random_subset = random_subset_size > 0 && random_subset_size < meshes.size();
int num_meshes = use_random_subset ? random_subset_size : meshes.size();

Expand Down
Loading