Introducing generic typing in MultiJob for self.children#399
Open
SiebeLeDe wants to merge 4 commits into
Open
Conversation
…hat accepts a List or Dict containing any type of Job
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #398 about type errors because the self.children attribute in
MultiJobwas not generically typed.Changes
MultiJobclass, including the methodsnew_children,other_jobs,remove_child, and dunder method__iter__self.childrentype fromList[J]toUnion[List[J], Dict[J]]No (new) tests have been written since these changes only affect the Python linter and typechecker in the text editor.