Skip to content

Conversation

@Sichao25
Copy link
Contributor

Create self-hosted CI using the environments from the PR #220 .

Note: This should be tested after the GPU debug changes #227 are merged.

@jacobmerson jacobmerson mentioned this pull request Dec 7, 2025
@jacobmerson
Copy link
Collaborator

Do we know this PR is not trying to launch jobs on the self-hosted runner? It looks like you essentially copy pasted what I had in #220. The only thing that comes to mind as a possibility is the name in the yaml doesn't match the filename.

Otherwise, I wonder if there is some repo setting we need to change.

@Sichao25
Copy link
Contributor Author

Sichao25 commented Dec 9, 2025

I haven't figured out the reason yet. Is our ASICS environment configured for all branches or just selected branches?

@jacobmerson
Copy link
Collaborator

jacobmerson commented Dec 9, 2025

@Sichao25 I think I fixed why it wasn't running. It turns out that the yml file needed to be inside the workflows folder. Please try pushing an empty commit to make sure the workflow still runs when you push and it's not related to some user permissions.

@Sichao25
Copy link
Contributor Author

Sichao25 commented Dec 9, 2025

Thanks a lot for spotting that! Didn't realize it was using the wrong directory.

@jacobmerson jacobmerson marked this pull request as ready for review December 9, 2025 22:12
@jacobmerson
Copy link
Collaborator

Looks like it's working. I got the request for the deployment. I'm going to mark this ready for review.

@cwsmith do you want to review this PR? I think it's all set, but since there may be some security implications I rather get a third set of eyes.

@Sichao25
Copy link
Contributor Author

Sichao25 commented Dec 9, 2025

I might need to update the configuration with the latest branch before merging.

@Sichao25
Copy link
Contributor Author

Blocked by SCOREC/omega_h#196. Let me know if you have suggestions for a better approach.

@Sichao25
Copy link
Contributor Author

Does it matter if I squash those debug commits?

@jacobmerson
Copy link
Collaborator

Go ahead and squash all the debug commits.

@jacobmerson
Copy link
Collaborator

I will merge this as soon as I get approval from @cwsmith.

@jacobmerson
Copy link
Collaborator

jacobmerson commented Dec 16, 2025

My guess is this failure

/space/d_zxg05646/asics-actions-runner-linux-x64-2.323.0/_work/pcms/pcms/pcmsCI_2025-12-16-12-50/build-pcms/test/test_interpolation_fortran_api: error while loading shared libraries: libmpicxx.so.12: cannot open shared object file: No such file or directory

means that we may need to specify that we are linking against MPI in the fortran api here:

target_link_libraries(pcms_fortranapi_interpolator PRIVATE pcms::capi::interpolator PUBLIC Kokkos::kokkos)

Or possibly, it needs to be set to be a PUBLIC dependency of the capi?

It's interesting that the the normal github action runners didn't catch this.

@Sichao25
Copy link
Contributor Author

Yes, MPI needs to be added to LD_LIBRARY_PATH for that test to pass.

@jacobmerson
Copy link
Collaborator

Shouldn't the mpi module add mpi to the LD_LIBRARY_PATH?

@Sichao25
Copy link
Contributor Author

It might not be the case by default if I understand correctly. Here is the related doc.

@jacobmerson jacobmerson merged commit ff2a2b9 into SCOREC:develop Dec 21, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants