-
Notifications
You must be signed in to change notification settings - Fork 16
Create self hosted CI #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Do we know this PR is not trying to launch jobs on the self-hosted runner? It looks like you essentially copy pasted what I had in #220. The only thing that comes to mind as a possibility is the name in the yaml doesn't match the filename. Otherwise, I wonder if there is some repo setting we need to change. |
|
I haven't figured out the reason yet. Is our ASICS environment configured for all branches or just selected branches? |
|
@Sichao25 I think I fixed why it wasn't running. It turns out that the yml file needed to be inside the workflows folder. Please try pushing an empty commit to make sure the workflow still runs when you push and it's not related to some user permissions. |
|
Thanks a lot for spotting that! Didn't realize it was using the wrong directory. |
|
Looks like it's working. I got the request for the deployment. I'm going to mark this ready for review. @cwsmith do you want to review this PR? I think it's all set, but since there may be some security implications I rather get a third set of eyes. |
|
I might need to update the configuration with the latest branch before merging. |
|
Blocked by SCOREC/omega_h#196. Let me know if you have suggestions for a better approach. |
|
Does it matter if I squash those debug commits? |
|
Go ahead and squash all the debug commits. |
da50952 to
c417a6d
Compare
|
I will merge this as soon as I get approval from @cwsmith. |
|
My guess is this failure means that we may need to specify that we are linking against MPI in the fortran api here: pcms/src/pcms/fortranapi/CMakeLists.txt Line 25 in d50b976
Or possibly, it needs to be set to be a It's interesting that the the normal github action runners didn't catch this. |
|
Yes, MPI needs to be added to LD_LIBRARY_PATH for that test to pass. |
|
Shouldn't the mpi module add mpi to the |
|
It might not be the case by default if I understand correctly. Here is the related doc. |
acfa8ae to
ab458c6
Compare
0d31bcd to
9467080
Compare
Create self-hosted CI using the environments from the PR #220 .
Note: This should be tested after the GPU debug changes #227 are merged.