Skip to content

Kate and Monica HTML5 architecture #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KateFleming wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Kate and Monica HTML5 architecture #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 87 additions & 0 deletions HTML5Rebuild.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
<!DOCTYPE html>
<html>

<head>
<meta charset="utf-8">
<title>Semantic HTML5</title>
</head>

<body>

<header>
<h1><button><img src="#"></button></h1>
<nav class="primarynav">
<ul class=" firstul">
<l1 class="first">Courses</l1>
<li class="first">Grades</li>
<li class="first">Calendar</li>
</ul>
<nav class="secondnav">
<ul class="secondul">
<li class="second">Student Name</li>
<li class="second">Inbox</li>
< li class="second">Settings</li>
<li class="second">Logout</li>
<li class="second">Help</li>
</ul>
</nav>
</nav>
</header>


<section class="Lnav">
Copy link
Copy Markdown

@litteredwitherrors litteredwitherrors Oct 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better convention to keep class names lower case.

Copy link
Copy Markdown

@litteredwitherrors litteredwitherrors Oct 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a nav, it should be a nav.

<h2>B25:</h2>
<ul class="leftvertical">
<li class="left">Home</li>
<li class="left">Assignments</li>
<li class="left">Discussions</li>
<li class="left">Grades</li>
<li class="left">People</li>
<li class="left">Pages</li>
<li class="left">Syllabus</li>
<li class="left">Modules</li>
<li class="left">Conferences</li>
<li class="left">Collaborations</li>
</ul>
</section>

Copy link
Copy Markdown

@litteredwitherrors litteredwitherrors Oct 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bunch of of unnecessary extra lines.


<section class="main">
<h1>Semantic HTML5</h1>
<p class="inside"><strong>Due</strong>
Copy link
Copy Markdown

@litteredwitherrors litteredwitherrors Oct 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What reason did you use the strong tags here?

<time datetime="13:00"></time>Yesterday by 1pm</p>
<p class="inside"><strong>Points</strong>10</p>
<p class="inside"><strong>Submitting</strong>a text entry box or a website URL</p>
<h2>Semantic HTML5 Rebuild</h2>
<p class="mainp">For this assignment will be done in pairs.</p>
<p class="mainp">Fork, clone and add your assignment in a folder named after your team ("bob-sandy") then send a pull request: https://github.com/SEA-Design-Dev/HTML5-architecture-and-semantics (Links to an external site.)</p>
<p class="mainp">Rebuild a page of your choice using semantic architecture.</p>
<ol class="insideul">
<li class="insideli">
Make sure that you are using the principals of the h5bp correctly</li>
<li class="insideli">Ensure that you are using semantically correct HTML examples</li>
</ol>
</section>


<aside>
Copy link
Copy Markdown

@litteredwitherrors litteredwitherrors Oct 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear on the purpose of this.

<h2>Submit Assignment</h2>
</aside>


<footer>

<nav class="bottomnav">
<ul class="bottom">
<li class="btm">Help</li>
<li class="btm">Privacy policy</li>
<li class="btm">Terms of service</li>
<li class="btm">Facebook</li>
<li class="btm">Twitter</li>
</ul>
</nav>
</footer>

</body>

</html>
Copy link
Copy Markdown

@litteredwitherrors litteredwitherrors Oct 30, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an extra blank line.