Ellis's Personal API #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conmart
reviewed
Sep 5, 2017
|
|
||
| function index(req, res){ | ||
| db.Project.find({}, function(err, allProjects) { | ||
| if (err) |
There was a problem hiding this comment.
Do you need these guys {} for the if statement?
There was a problem hiding this comment.
Not needed, but certainly encouraged (and required by pretty much every styleguide) to avoid the goto fail.
conmart
reviewed
Sep 5, 2017
| </div> | ||
| </div> | ||
|
|
||
| <!-- Text input--> |
There was a problem hiding this comment.
Looks like "deployed" is misspelled in this input of the form
mnfmnfm
reviewed
Sep 6, 2017
mnfmnfm
left a comment
mnfmnfm
left a comment
There was a problem hiding this comment.
The code you have here is mostly beautiful, but it's a shame that it didn't get through having edit/delete working from your frontend.
|
|
||
| function index(req, res){ | ||
| db.Project.find({}, function(err, allProjects) { | ||
| if (err) |
There was a problem hiding this comment.
Not needed, but certainly encouraged (and required by pretty much every styleguide) to avoid the goto fail.
|
|
||
| function create(req, res){ | ||
| db.Project.create(req.body, function(err, project) { | ||
| if (err) { console.log('error', err); } |
| db.Project.findByIdAndUpdate(req.params.id, req.body, {new: true}, function (err, project){ | ||
| res.json(project); | ||
| }); | ||
| } |
There was a problem hiding this comment.
short and sweet controllers are awesome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be gentle