Allow retrieving nyan::Object handle as shared_ptr#124
Merged
TheJJ merged 1 commit intoSFTtech:masterfrom May 10, 2025
Merged
Conversation
3 tasks
TheJJ
approved these changes
May 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows fetching a
nyan::Objectfrom anyan::Viewasstd::shared_ptr.Even though
nyan/nyan/object.h
Lines 63 to 67 in 19e742a
The main motivation for this change is a change to the activity system in openage PR SFTtech/openage#1688 to include
nyan::Objects. Using raw objects/references makes testing the activity system more complicated as it requires us to initialize a whole nyan database for the tests. If we use shared pointers, we can get away with nullptr wrapped in shared_ptr as a workaround.