Conversation
|
I'm waiting for #125 on this one, in case that needs reformatting. |
heinezen
force-pushed
the
chore/clang_format_update
branch
from
3c0b06c to
44ef5ff
Compare
| if (unlikely(member_info.is_initial_def())) { | ||
| // another parent defines this type, | ||
| // which is disallowed! | ||
| // which is disallowed! |
There was a problem hiding this comment.
this should remain one-tab indented, just like the line before.
There was a problem hiding this comment.
I tested why this is happening and it looks like this is the trade-off of turning ReflowComments on. The multi-line block comments are formatted correctly now (with tabs), but multiple single-line comments get converted to spaces for whatever reason.
There was a problem hiding this comment.
oh dear. that surely seems like a bug then. so far i couldn't find an upstream report about this...
There was a problem hiding this comment.
seems like a bad interaction of ReflowComments and UseTabs...
| } | ||
| // else that member knows the type, | ||
| // but we're looking for the initial definition. | ||
| // but we're looking for the initial definition. |
| target_obj->apply( | ||
| // TODO: use the same mechanism as above to get only parent | ||
| // obj states of base_state | ||
| // obj states of base_state |
nyan/value/number.cpp
Outdated
|
|
||
| // explicit instantiations | ||
| template class Number<value_int_t>; // Int | ||
| template class Number<value_int_t>; // Int |
There was a problem hiding this comment.
same here, comment lineup is likely bad
nyan/value/number.h
Outdated
| INF_POS, //!< set this to positive infinite | ||
| INF_NEG, //!< set this to negative infinite | ||
| ZERO, //!< set this to zero | ||
| ZERO, //!< set this to zero |
heinezen
force-pushed
the
chore/clang_format_update
branch
4 times, most recently
from
3011ade to
40f41fb
Compare
heinezen
force-pushed
the
chore/clang_format_update
branch
from
40f41fb to
3e4fb5a
Compare
|
I fixed everything I could. About the spaces in the indentation of the comments: Let's accept that these exist because |
|
Great, thanks! |
2 participants
Updates the clang format rules to a newer clang-format version. I also tried to sync the rules with the openage formatting (see here).