chore: bump version to 1.21.11-2.59.1 and fix button labels in SearchDialog#221
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the SURF-API Bukkit module by bumping the published version and adjusting the confirmation-button wiring in SearchDialog to correct the displayed button labeling/behavior.
Changes:
- Bump project version from
1.21.11-2.59.0to1.21.11-2.59.1. - Swap
yes/noaction button blocks inSearchDialog’s confirmation type to address the search/cancel button labeling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| surf-api-bukkit/surf-api-bukkit-api/src/main/kotlin/dev/slne/surf/surfapi/bukkit/api/dialog/search/SearchDialog.kt | Swaps confirmation yes/no button blocks for search vs cancel actions. |
| gradle.properties | Bumps the library version to 1.21.11-2.59.1. |
| confirmation { | ||
| yes { | ||
| no { | ||
| label(searchButton.label) | ||
| tooltip(searchButton.tooltip) |
There was a problem hiding this comment.
In this confirmation dialog, the primary/positive action (search) is now wired under no { ... }. Given the DSL and underlying Paper API use yes/no semantics, this reads backwards and is easy to misinterpret/maintain. If this swap is needed due to client button ordering, consider fixing the mapping in the dialog confirmation builder (so call sites can keep yes = confirm/search) or add an explicit helper/clarifying comment to avoid future mistakes.
|
|
||
| no { | ||
| yes { | ||
| label(cancelButton.label) | ||
| tooltip(cancelButton.tooltip) |
There was a problem hiding this comment.
Similarly, the cancel/negative action is now under yes { ... }. If yes is treated as the default/affirmative action by the client (e.g., default focus/Enter key), this could lead to unexpected UX. Prefer keeping yes aligned with the affirmative action (search) and addressing any ordering/label issue in the builder layer instead.
No description provided.