Feat/error logging system by ammodev · Pull Request #11 · SLNE-Development/surf-core

ammodev · 2026-02-08T15:19:56Z

No description provided.

…Listener

…tication flow

…AuthenticationListener and PlayerConnectListener

…ificationService

…ate references

…urfCoreError

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

…anup Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

…error handling Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

…dling

…structure' into copilot/implement-error-logging-structure

…ling

…gin check to listener Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

…rvice implementations

…logging-structure Implement system-wide error logging with automatic deduplication and MCCoroutine integration

…stener

Copilot

Pull request overview

Introduces a cross-platform (Paper + Velocity) error logging system that persists player-facing error codes and system exceptions to the backend database, and adds admin commands to inspect logged errors.

Changes:

Added global + coroutine exception handling that logs “system errors” to the database (with occurrence aggregation).
Added player error-code logging via SurfCoreApi.logError(...), plus shared disconnect message rendering that includes a copyable error code.
Added backend DB tables/repositories/services and Paper commands to view player/system error logs.

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/listener/MCCoroutineExceptionListener.kt	New Velocity listener to capture MCCoroutine exceptions and persist them as system errors
surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/auth/AuthenticationService.kt	Renames authentication service and logs failed authentication attempts via SurfCore API
surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/auth/AuthenticationListener.kt	Adds blocked-domain error-code logging + new disconnect message rendering
surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/api/SurfCoreApiVelocityImpl.kt	Implements new SurfCore API error logging methods on Velocity
surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/VelocityMain.kt	Installs global error handler and registers new exception listener
surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/permission/PermissionRegistry.kt	Adds permission for new error-related commands
surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/listener/PlayerConnectListener.kt	Logs player-data load failures and kicks with error-code disconnect message
surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/listener/MCCoroutineExceptionListener.kt	New Paper listener to capture MCCoroutine exceptions and persist as system errors
surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/command/TestErrorCommand.kt	New command to trigger test errors for validating the logging pipeline
surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/command/SurfCoreSystemErrorCommand.kt	New command to list/view aggregated system errors
surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/command/CoreErrorCommand.kt	New command to view player error-code logs
surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/api/SurfCoreApiPaperImpl.kt	Implements new SurfCore API error logging methods on Paper
surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/PaperMain.kt	Installs global error handler, registers new listener, and registers new commands
surf-core-core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/util/core-common-util.kt	Adds reusable disconnect message builders including error-code rendering
surf-core-core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/player/SurfCoreErrorLoggingService.kt	New common service interface for persisting player error-code logs
surf-core-core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/error/SurfCoreSystemErrorService.kt	New common service interface for persisting aggregated system errors + location extraction
surf-core-core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/error/GlobalErrorHandler.kt	New global uncaught exception handler that persists system errors asynchronously
surf-core-core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/SurfCoreApiImpl.kt	Adds shared SurfCore API “awaiting” error logging methods + code generation passthrough
surf-core-backend/src/main/kotlin/dev/slne/surf/core/fallback/table/SurfCoreSystemErrorTable.kt	New DB table for aggregated system errors (message/location/server unique key)
surf-core-backend/src/main/kotlin/dev/slne/surf/core/fallback/table/SurfCoreErrorLogsTable.kt	New DB table for player error-code logs
surf-core-backend/src/main/kotlin/dev/slne/surf/core/fallback/service/SurfCoreSystemErrorServiceImpl.kt	Backend implementation of system error persistence service
surf-core-backend/src/main/kotlin/dev/slne/surf/core/fallback/service/SurfCoreErrorLoggingServiceImpl.kt	Backend implementation of player error-code logging service
surf-core-backend/src/main/kotlin/dev/slne/surf/core/fallback/repository/SurfCoreSystemErrorRepository.kt	Repository for upserting system errors and incrementing occurrence counts
surf-core-backend/src/main/kotlin/dev/slne/surf/core/fallback/repository/SurfCoreErrorLoggingRepository.kt	Repository for inserting and retrieving player error-code logs
surf-core-backend/src/main/kotlin/dev/slne/surf/core/fallback/DatabaseLoaderImpl.kt	Registers new tables for schema creation/migration
surf-core-api/surf-core-api-common/src/main/kotlin/dev/slne/surf/core/api/common/error/SurfCoreSystemError.kt	New API DTO for system errors
surf-core-api/surf-core-api-common/src/main/kotlin/dev/slne/surf/core/api/common/error/SurfCoreError.kt	New API DTO for player error-code logs
surf-core-api/surf-core-api-common/src/main/kotlin/dev/slne/surf/core/api/common/SurfCoreApi.kt	Adds new error logging API surface (sync + awaiting variants)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-08T15:25:08Z

...-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/error/GlobalErrorHandler.kt

+    fun shutdown() {
+        runBlocking {
+            try {
+                errorScope.coroutineContext.job.cancelAndJoin()
+                logger.info("Global error handler shutdown complete")


shutdown() cancels the entire errorScope job (cancelAndJoin()), which also cancels any in-flight DB logging coroutines and may drop errors during shutdown. Consider awaiting completion of existing children (optionally with a timeout) before cancelling the scope, if you want best-effort persistence.

Copilot · 2026-02-08T15:25:08Z

surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/command/SurfCoreSystemErrorCommand.kt

+                if (row.location.length > 50) {
+                    spacer("...")
+                }
+                clickRunsCommand("/systemerror view ${row.id}")


The click action runs /systemerror view <id>, but the registered command is surfcoresystemerror view <id>. Update the click command (or add an alias) so clicking a row opens the details view.

Suggested change

clickRunsCommand("/systemerror view ${row.id}")

clickRunsCommand("/surfcoresystemerror view ${row.id}")

Copilot · 2026-02-08T15:25:08Z

...kend/src/main/kotlin/dev/slne/surf/core/fallback/repository/SurfCoreSystemErrorRepository.kt

+            it[SurfCoreSystemErrorTable.server] = server
+            it[SurfCoreSystemErrorTable.firstOccurred] = existingError?.firstOccurred ?: now
+            it[SurfCoreSystemErrorTable.lastOccurred] = now
+            it[SurfCoreSystemErrorTable.occurrenceCount] = (existingError?.occurrenceCount ?: 0) + 1


occurrenceCount is computed from a previously read existingError and then written back as existing + 1. Under concurrent logging of the same error this can lose increments (two transactions can both read N and write N+1). Prefer an atomic DB-side increment in the upsert conflict update (e.g., occurrence_count = occurrence_count + 1).

Suggested change

it[SurfCoreSystemErrorTable.occurrenceCount] = (existingError?.occurrenceCount ?: 0) + 1

it[SurfCoreSystemErrorTable.occurrenceCount] =

if (existingError == null) 1 else SurfCoreSystemErrorTable.occurrenceCount + 1

Copilot · 2026-02-08T15:25:09Z

...elocity/src/main/kotlin/dev/slne/surf/core/velocity/listener/MCCoroutineExceptionListener.kt

+    fun onMCCoroutineException(event: MCCoroutineExceptionEvent) {
+        event.result = ResultedEvent.GenericResult.denied()
+
+        logger.log(Level.SEVERE, "MCCoroutine exception occurred", event.exception)


The Velocity MCCoroutine exception handler logs/persists all exceptions. Consider ignoring CancellationException (as done in the Paper listener) to avoid noisy logs/DB writes when coroutines are cancelled as part of normal control flow.

Copilot · 2026-02-08T15:25:09Z

surf-core-backend/src/main/kotlin/dev/slne/surf/core/fallback/table/SurfCoreErrorLogsTable.kt

+    val errorCode = varchar("error_code", 7)
+    val errorMessage = text("error_message")
+    val server = varchar("server", 255)
+    val timestamp = offsetDateTime("timestamp")


This table is queried by error_code (getError(code)) and by player_uuid (getErrors(uuid)), but defines no indexes/uniqueness. Consider adding indexes (and likely a uniqueness constraint on error_code if codes must be unambiguous for support).

Suggested change

val timestamp = offsetDateTime("timestamp")

val timestamp = offsetDateTime("timestamp")

init {

// Index for lookups by player UUID (e.g., getErrors(uuid))

index(isUnique = false, columns = arrayOf(playerUuid))

// Index for lookups by error code (e.g., getError(code))

index(isUnique = false, columns = arrayOf(errorCode))

}

Copilot · 2026-02-08T15:25:09Z

...elocity/src/main/kotlin/dev/slne/surf/core/velocity/listener/MCCoroutineExceptionListener.kt

+            runBlocking {
+                launch {
+                    try {
+                        val surfCoreSystemError = surfCoreSystemErrorService.logError(
+                            throwable = event.exception,


runBlocking inside an event callback can block the Velocity event thread if the DB is slow/unavailable, potentially stalling the proxy. Prefer launching the DB logging asynchronously on a plugin/IO scope and remove the redundant launch nested inside runBlocking.

Copilot · 2026-02-08T15:25:10Z

surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/auth/AuthenticationListener.kt

+                    val errorCode = surfCoreApi.logError(
+                        event.player.uniqueId,
+                        code,
+                        "Blocked connection from domain: $domain"
+                    )


surfCoreApi.logError(playerUuid, code, message) returns Unit, so val errorCode = ... is always Unit and unused. Either remove the variable assignment, or use the 2-arg overload (logError(uuid, message)) that returns the generated code and reuse it in the disconnect message.

surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/api/SurfCoreApiVelocityImpl.kt

Copilot · 2026-02-08T15:25:10Z

surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/api/SurfCoreApiPaperImpl.kt

+    override fun logError(playerUUid: UUID, message: String): String {
+        val code = surfCoreErrorLoggingService.generateCode()
+
+        plugin.launch {
+            surfCoreErrorLoggingService.logError(
+                playerUUid,


Parameter name playerUUid is inconsistent with the API (playerUuid). Rename it to playerUuid for consistency/readability across implementations.

Suggested change

override fun logError(playerUUid: UUID, message: String): String {

val code = surfCoreErrorLoggingService.generateCode()

plugin.launch {

surfCoreErrorLoggingService.logError(

playerUUid,

override fun logError(playerUuid: UUID, message: String): String {

val code = surfCoreErrorLoggingService.generateCode()

plugin.launch {

surfCoreErrorLoggingService.logError(

playerUuid,

Copilot · 2026-02-08T15:25:10Z

...-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/error/GlobalErrorHandler.kt

+                    val surfCoreSystemError = surfCoreSystemErrorService.logError(
+                        throwable = throwable,
+                        server = SurfServer.current().name


handleError uses SurfServer.current().name, which can throw if the current server hasn't been registered in surfServerService yet (e.g., very early startup). Use a non-throwing source for the server name (like surfCoreApi.getCurrentServerName() or a safe fallback) so the global handler can still persist errors during initialization.

Suggested change

val surfCoreSystemError = surfCoreSystemErrorService.logError(

throwable = throwable,

server = SurfServer.current().name

val serverName = try {

SurfServer.current().name

} catch (e: Exception) {

logger.log(

Level.WARNING,

"Failed to resolve current SurfServer name while handling an error; using fallback name.",

e

)

"unknown"

}

val surfCoreSystemError = surfCoreSystemErrorService.logError(

throwable = throwable,

server = serverName

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

…or-system-errors Add 10-character error codes to system errors

Copilot

Pull request overview

Copilot reviewed 26 out of 26 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-08T16:52:11Z

surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/command/CoreErrorCommand.kt

+                        success("Triggering exception with custom context...")
+
+                        plugin.launch(plugin.globalRegionDispatcher) {
+                            error("Test exception with custom context from /testerror customContext")


The thrown test exception message references /testerror customContext, but the actual command path is /coreerror system test customContext. Update the string to match so logs are easier to correlate.

Suggested change

error("Test exception with custom context from /testerror customContext")

error("Test exception with custom context from /coreerror system test customContext")

Copilot · 2026-02-08T16:52:11Z

...kend/src/main/kotlin/dev/slne/surf/core/fallback/repository/SurfCoreSystemErrorRepository.kt

+                (SurfCoreSystemErrorTable.errorMessage eq message) and
+                        (SurfCoreSystemErrorTable.location eq location) and
+                        (SurfCoreSystemErrorTable.server eq server) and
+                        (SurfCoreSystemErrorTable.lastOccurred lessEq now.minusDays(1))


The existingError lookup uses lastOccurred <= now.minusDays(1), which matches errors last seen more than 24h ago. That inverts typical “dedupe/count within last 24h” behavior and will create new rows for duplicates happening within 24h; adjust the comparison/window logic.

Copilot · 2026-02-08T16:52:11Z

...elocity/src/main/kotlin/dev/slne/surf/core/velocity/listener/MCCoroutineExceptionListener.kt

+    @Subscribe
+    fun onMCCoroutineException(event: MCCoroutineExceptionEvent) {
+        event.result = ResultedEvent.GenericResult.denied()


Unlike the Paper listener, this Velocity listener does not filter out cancellation-related exceptions (e.g., CancellationException). Those are typically expected and can produce noisy severe logs; consider ignoring them early in the handler.

Copilot · 2026-02-08T16:52:12Z

surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/command/CoreErrorCommand.kt

+                        success("Triggering coroutine exception...")
+                    }
+
+                    error("Test coroutine exception from /testerror coroutine")


The thrown test exception message references /testerror coroutine, but the actual command path is /coreerror system test coroutine. Update the string to match so logs are easier to correlate.

Suggested change

error("Test coroutine exception from /testerror coroutine")

error("Test coroutine exception from /coreerror system test coroutine")

Copilot · 2026-02-08T16:52:12Z

surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/command/CoreErrorCommand.kt

+                    }
+
+                    plugin.launch {
+                        error("Test exception from plugin.launch in /testerror launch")


The thrown test exception message references /testerror launch, but the actual command path is /coreerror system test launch. Update the string to match so logs are easier to correlate.

Suggested change

error("Test exception from plugin.launch in /testerror launch")

error("Test exception from plugin.launch in /coreerror system test launch")

Copilot · 2026-02-08T16:52:12Z

surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/auth/AuthenticationListener.kt

+                    }
+
+                    val code = surfCoreErrorLoggingService.generateCode()
+                    val errorCode = surfCoreApi.logError(


surfCoreApi.logError(playerUuid, code, message) returns Unit, but its result is assigned to val errorCode. This will not compile (type mismatch) and the variable is unused; remove the assignment or call the String-returning overload if you need a code.

Suggested change

val errorCode = surfCoreApi.logError(

surfCoreApi.logError(

Copilot · 2026-02-08T16:52:12Z

...elocity/src/main/kotlin/dev/slne/surf/core/velocity/listener/MCCoroutineExceptionListener.kt

+        runCatching {
+            runBlocking {
+                launch {
+                    runCatching {
+                        val surfCoreSystemError = surfCoreSystemErrorService.logError(


runBlocking inside this event handler will block the Velocity event thread until the DB logging completes (and the nested launch is redundant because runBlocking waits for its children). Prefer launching the logging work on a background scope/dispatcher without blocking this handler.

...core-paper/src/main/kotlin/dev/slne/surf/core/paper/listener/MCCoroutineExceptionListener.kt

Copilot · 2026-02-08T16:52:13Z

surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/command/CoreErrorCommand.kt

+                    Thread {
+                        error("Test thread exception from /testerror thread")
+                    }.start()


The thrown test exception message references /testerror thread, but the actual command path is /coreerror system test thread. Update the string to match so logs are easier to correlate.

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

…st-command Add filtering support to error list commands

…ering logic

Copilot

Pull request overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...core-paper/src/main/kotlin/dev/slne/surf/core/paper/listener/MCCoroutineExceptionListener.kt

Copilot · 2026-02-08T17:18:18Z

...kend/src/main/kotlin/dev/slne/surf/core/fallback/repository/SurfCoreSystemErrorRepository.kt

+            .map { row ->
+                SurfCoreSystemError(
+                    uuid = row[SurfCoreSystemErrorTable.uuid],
+                    errorCode = row[SurfCoreSystemErrorTable.errorCode],
+                    errorMessage = row[SurfCoreSystemErrorTable.errorMessage],


After the upsert, the code re-selects by (errorMessage, location, server) without ordering or a time window. If multiple rows exist for the same triple (e.g., after the 24h window where a new row is inserted), firstOrNull() can return an older record and report the wrong uuid/errorCode. Select deterministically (e.g., by the uuid/errorCode you just wrote, or order by lastOccurred desc and limit 1).

Copilot · 2026-02-08T17:18:18Z

...kend/src/main/kotlin/dev/slne/surf/core/fallback/repository/SurfCoreSystemErrorRepository.kt

+            )
+            .map { row ->
+                SurfCoreSystemError(
+                    uuid = row[SurfCoreSystemErrorTable.uuid],
+                    errorCode = row[SurfCoreSystemErrorTable.errorCode],
+                    errorMessage = row[SurfCoreSystemErrorTable.errorMessage],
+                    stacktrace = row[SurfCoreSystemErrorTable.stacktrace],


The “dedupe within 24h” logic does a SELECT then an UPSERT, but there is no uniqueness constraint on (errorMessage, location, server) to prevent concurrent log calls from inserting multiple rows for the same error. If you need deduplication, consider enforcing a unique key that matches the dedupe criteria (or otherwise serialize updates, e.g., via an explicit UPDATE/INSERT strategy).

Copilot · 2026-02-08T17:18:18Z

...end/src/main/kotlin/dev/slne/surf/core/fallback/repository/SurfCoreErrorLoggingRepository.kt

+    suspend fun getError(code: String): SurfCoreError? = suspendTransaction {
+        SurfCoreErrorLogsTable.selectAll().where(SurfCoreErrorLogsTable.errorCode eq code).map {
+            SurfCoreError(
+                playerUuid = it[SurfCoreErrorLogsTable.playerUuid],
+                code = it[SurfCoreErrorLogsTable.errorCode],
+                message = it[SurfCoreErrorLogsTable.errorMessage],
+                server = it[SurfCoreErrorLogsTable.server],
+                timestamp = it[SurfCoreErrorLogsTable.timestamp]
+            )
+        }.firstOrNull()


getError(code) assumes error_code uniquely identifies a single player error log, but the table schema does not enforce uniqueness on error_code. Even if collisions are rare, this can return the wrong player's error. Either enforce uniqueness at the DB level (and retry on conflict when generating codes) or change the lookup API to include a disambiguator (e.g., player UUID + code, or code + timestamp).

Suggested change

suspend fun getError(code: String): SurfCoreError? = suspendTransaction {

SurfCoreErrorLogsTable.selectAll().where(SurfCoreErrorLogsTable.errorCode eq code).map {

SurfCoreError(

playerUuid = it[SurfCoreErrorLogsTable.playerUuid],

code = it[SurfCoreErrorLogsTable.errorCode],

message = it[SurfCoreErrorLogsTable.errorMessage],

server = it[SurfCoreErrorLogsTable.server],

timestamp = it[SurfCoreErrorLogsTable.timestamp]

)

}.firstOrNull()

suspend fun getError(playerUuid: UUID, code: String): SurfCoreError? = suspendTransaction {

SurfCoreErrorLogsTable

.selectAll()

.where(

SqlExpressionBuilder.run {

(SurfCoreErrorLogsTable.playerUuid eq playerUuid) and

(SurfCoreErrorLogsTable.errorCode eq code)

}

)

.map {

SurfCoreError(

playerUuid = it[SurfCoreErrorLogsTable.playerUuid],

code = it[SurfCoreErrorLogsTable.errorCode],

message = it[SurfCoreErrorLogsTable.errorMessage],

server = it[SurfCoreErrorLogsTable.server],

timestamp = it[SurfCoreErrorLogsTable.timestamp]

)

}

.firstOrNull()

…eErrorLoggingRepository

…in CoreErrorCommand

…-fix-server-info-command

…d-fix-server-info-command' into feat/error-logging-system # Conflicts: # surf-core-api/surf-core-api-common/src/main/kotlin/dev/slne/surf/core/api/common/SurfCoreApi.kt # surf-core-core/surf-core-core-common/src/main/kotlin/dev/slne/surf/core/core/common/SurfCoreApiImpl.kt # surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/PaperMain.kt # surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/api/SurfCoreApiPaperImpl.kt # surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/listener/PlayerConnectListener.kt # surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/VelocityMain.kt # surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/api/SurfCoreApiVelocityImpl.kt # surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/auth/AuthenticationListener.kt

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-22T09:56:39Z

surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/auth/AuthenticationListener.kt

+        authenticationService.continuations[event.player.uniqueId] = continuation
+        event.player.requestCookie(authenticationService.key)
        transfers.add(event.player.uniqueId)

-        authentificationService.continuations[event.player.uniqueId] = continuation
-        event.player.requestCookie(authentificationService.key)
+        authenticationService.continuations[event.player.uniqueId] = continuation
+        event.player.requestCookie(authenticationService.key)


authenticationService.continuations[...] = continuation and requestCookie(...) are executed twice for the same login (lines 71–76). This will trigger duplicate cookie requests and can lead to hard-to-debug auth/continuation behavior. Remove the duplicated block so it only runs once.

Copilot · 2026-02-22T09:56:40Z

surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/listener/PlayerConnectListener.kt

+            runBlocking {
+                val code = surfCoreApi.logError(
+                    event.connection.audience.uuid(),
+                    "Failed to load player data on AsyncPlayerPreLoginEvent"
+                )


runBlocking inside AsyncPlayerConnectionConfigureEvent will block the async login/config thread even though surfCoreApi.logError(uuid, message) already returns a code immediately and logs asynchronously. Prefer calling logError(...) directly (no runBlocking) and disconnect right away with the returned code.

Copilot · 2026-02-22T09:56:40Z

surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/command/CoreErrorCommand.kt

+
+                        plugin.launch(plugin.globalRegionDispatcher) {
+                            error("Test exception with custom context from /testerror customContext")
+                        }


In the customContext test command, plugin.launch(...) is executed inside the sendText { ... } builder. Mixing side effects into component-building makes the flow harder to reason about and can cause unexpected behavior if the builder is reused; move the launch call outside the message-building lambda.

Suggested change

plugin.launch(plugin.globalRegionDispatcher) {

error("Test exception with custom context from /testerror customContext")

}

}

plugin.launch(plugin.globalRegionDispatcher) {

error("Test exception with custom context from /testerror customContext")

Copilot · 2026-02-22T09:56:40Z

surf-core-paper/src/main/kotlin/dev/slne/surf/core/paper/command/CoreErrorCommand.kt

+                    Thread {
+                        error("Test thread exception from /testerror thread")
+                    }.start()
+                }
+            }
+
+            literalArgument("coroutine") {
+                anyExecutorSuspend { executor, _ ->
+                    executor.sendText {
+                        appendSuccessPrefix()
+                        success("Triggering coroutine exception...")
+                    }
+
+                    error("Test coroutine exception from /testerror coroutine")
+                }
+            }
+
+            literalArgument("launch") {
+                anyExecutor { executor, _ ->
+                    executor.sendText {
+                        appendSuccessPrefix()
+                        success("Triggering exception in launch...")
+                    }
+
+                    plugin.launch {
+                        error("Test exception from plugin.launch in /testerror launch")
+                    }


The thrown test exceptions reference /testerror ... in their messages, but the command registered here is /coreerror .... This makes the log output misleading when operators try to reproduce an error; update the strings to match the actual command path.

Copilot · 2026-02-22T09:56:40Z

surf-core-velocity/src/main/kotlin/dev/slne/surf/core/velocity/auth/AuthenticationListener.kt

+                    val code = surfCoreErrorLoggingService.generateCode()
+                    val errorCode = surfCoreApi.logError(
+                        event.player.uniqueId,
+                        code,
+                        "Blocked connection from domain: $domain"
+                    )


In the blocked-domain branch, the result of surfCoreApi.logError(...) is assigned to val errorCode, but this overload returns Unit and the variable is never used. This is confusing and looks like a leftover from an earlier API design—either remove the variable or switch to the logError(uuid, message): String overload if you actually need a code.

Copilot · 2026-02-22T09:56:40Z

...kend/src/main/kotlin/dev/slne/surf/core/fallback/repository/SurfCoreSystemErrorRepository.kt

+        val resultError = SurfCoreSystemErrorTable.selectAll()
+            .where(
+                (SurfCoreSystemErrorTable.errorMessage eq message) and
+                        (SurfCoreSystemErrorTable.location eq location) and
+                        (SurfCoreSystemErrorTable.server eq server)
+            )
+            .map { row ->
+                SurfCoreSystemError(


After the upsert, the code re-selects by (message, location, server) without ordering. If there are multiple rows with the same triple (e.g., older than 24h plus a new one), firstOrNull() may return an arbitrary/old row instead of the one just inserted/updated. Re-select by the uuid/errorCode you upserted (or return values from the upsert) to make the result deterministic.

TheBjoRedCraft and others added 27 commits February 8, 2026 02:11

feat: implement error logging system for player connection failures

afa848e

feat: update error logging to use dynamic error code in PlayerConnect…

51841df

…Listener

feat: add core error command for viewing player errors and error codes

38cd40e

feat: enhance error logging and disconnect message handling in authen…

a0504ed

…tication flow

feat: refactor disconnect message handling to include error codes in …

de1eb94

…AuthenticationListener and PlayerConnectListener

feat: add error logging for failed authentication attempts in Authent…

ded7a43

…ificationService

feat: rename AuthentificationService to AuthenticationService and upd…

a4f943d

…ate references

feat: fix typo in logError method parameter name in SurfCoreApi

ef2f04f

feat: add player UUID to error logging and enhance error details in S…

14208a3

…urfCoreError

Initial plan

eb50f72

feat: enhance error logging with stacktrace, location, and deduplication

505a898

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

feat: implement separate system error logging infrastructure

68beaf7

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

fix: address code review feedback - lifecycle management and code cle…

5ed9264

…anup Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

docs: add comprehensive implementation summary

bc984a3

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

feat: add MCCoroutine exception event listeners for proper coroutine …

582d5d8

…error handling Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

docs: remove IMPLEMENTATION_SUMMARY.md and SYSTEM_ERROR_LOGGING.md

ee7d519

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

feat: implement error logging structure with improved server name han…

a14d9bc

…dling

Merge remote-tracking branch 'origin/copilot/implement-error-logging-…

21b9eab

…structure' into copilot/implement-error-logging-structure

feat: add launch command to trigger exceptions for testing error hand…

d22f196

…ling

fix: correct /testerror coroutine to use suspend executor and add plu…

043b624

…gin check to listener Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

feat: log error ID to console when errors are captured

2fa1c5a

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

fix: use upsert for atomic deduplication across restarts

dfdf5a6

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

refactor: remove documentation comments from code

d8516b6

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

refactor: rename SystemError to SurfCoreSystemError throughout codebase

c8267fe

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

refactor: rename SystemError to SurfCoreSystemError in command and se…

7f218cb

…rvice implementations

Merge pull request #10 from SLNE-Development/copilot/implement-error-…

3e817de

…logging-structure Implement system-wide error logging with automatic deduplication and MCCoroutine integration

refactor: remove unnecessary plugin check from MCCoroutineExceptionLi…

cd3cdb7

…stener

Copilot AI review requested due to automatic review settings February 8, 2026 15:19

Copilot started reviewing on behalf of ammodev February 8, 2026 15:20 View session

Copilot AI reviewed Feb 8, 2026

View reviewed changes

TheBjoRedCraft and others added 7 commits February 8, 2026 17:37

Merge branch 'version/1.21.11' into feat/error-logging-system

d6462c5

Initial plan

953e999

Add 10-character error code system for system errors

ad64038

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

Add unique constraint to error code and implement retry mechanism

4945931

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

Remove ineffective retry mechanism, rely on database uniqueness

fc258fb

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

Use error codes in command and logs for system errors

102b407

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

Merge pull request #12 from SLNE-Development/copilot/add-error-code-f…

5afb70a

…or-system-errors Add 10-character error codes to system errors

Copilot AI review requested due to automatic review settings February 8, 2026 16:47

Copilot started reviewing on behalf of TheBjoRedCraft February 8, 2026 16:47 View session

Copilot AI reviewed Feb 8, 2026

View reviewed changes

TheBjoRedCraft and others added 7 commits February 8, 2026 17:59

feat: enhance global error handling with detailed logging of exceptions

a392fdd

Initial plan

4e58870

Add filtering support to error list commands

fdc7647

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

Fix query building to use proper where clause construction

f693fd8

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

Improve code quality: Extract common functions and reduce duplication

40023b2

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

Extract andCondition helper to shared utility file

69a2844

Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com>

Merge pull request #13 from SLNE-Development/copilot/enhance-error-li…

aec80dc

…st-command Add filtering support to error list commands

Copilot AI review requested due to automatic review settings February 8, 2026 17:13

Copilot started reviewing on behalf of TheBjoRedCraft February 8, 2026 17:13 View session

feat: rename QueryUtils.kt to query-util.kt and streamline error filt…

d49107d

…ering logic

Copilot AI reviewed Feb 8, 2026

View reviewed changes

TheBjoRedCraft and others added 6 commits February 8, 2026 18:23

feat: streamline error handling logic in CoreErrorCommand and SurfCor…

cfb02b5

…eErrorLoggingRepository

feat: add error retrieval functionality for player and system errors …

5607948

…in CoreErrorCommand

feat: notify players of background system restart during proxy shutdown

62169e0

Merge branch 'version/1.21.11' into feat/proxy-shutdown-broadcast-and…

d273a1f

…-fix-server-info-command

feat: improve error logging and fix variable naming inconsistencies

dccb0b9

Copilot AI review requested due to automatic review settings February 22, 2026 09:51

Copilot started reviewing on behalf of TheBjoRedCraft February 22, 2026 09:51 View session

Copilot AI reviewed Feb 22, 2026

View reviewed changes

	clickRunsCommand("/systemerror view ${row.id}")
	clickRunsCommand("/surfcoresystemerror view ${row.id}")

	it[SurfCoreSystemErrorTable.occurrenceCount] = (existingError?.occurrenceCount ?: 0) + 1
	it[SurfCoreSystemErrorTable.occurrenceCount] =
	if (existingError == null) 1 else SurfCoreSystemErrorTable.occurrenceCount + 1

-    val timestamp = offsetDateTime("timestamp")
+    val timestamp = offsetDateTime("timestamp")
+    init {
+        // Index for lookups by player UUID (e.g., getErrors(uuid))
+        index(isUnique = false, columns = arrayOf(playerUuid))
+        // Index for lookups by error code (e.g., getError(code))
+        index(isUnique = false, columns = arrayOf(errorCode))
+    }

	error("Test exception with custom context from /testerror customContext")
	error("Test exception with custom context from /coreerror system test customContext")

	error("Test coroutine exception from /testerror coroutine")
	error("Test coroutine exception from /coreerror system test coroutine")

	error("Test exception from plugin.launch in /testerror launch")
	error("Test exception from plugin.launch in /coreerror system test launch")

Conversation

ammodev commented Feb 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment