Open
Conversation
dgboss
reviewed
Jul 11, 2023
| def get(self, request, format=None): | ||
| try: | ||
| # Extract bounding box Url parameter | ||
| bbstr = request.GET.get('bbox', '-180,-90,180,90') |
Contributor
There was a problem hiding this comment.
Consider pulling this out into a small helper function to reduce code duplication.
dgboss
approved these changes
Jul 11, 2023
Contributor
dgboss
left a comment
dgboss
left a comment
There was a problem hiding this comment.
Looks good, just a suggestion to factor out a helper function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds validation to bounding box input by user when downloading json data. Previously, an error parsing or using the bounding box params would result in a 500 error. Now server returns a more useful error message with status code 400 (bad request).
Example test:
bikemaps.org/incidents.json?bbox="-123.3,49.0,-122.7,49.3"
Opening a PR for review but pushing this branch to prod as a hotfix in the meantime.